[GitHub] [airflow] ashb commented on a change in pull request #6303: AIRFLOW-5126 Read aws_session_token in extra_config of the aws hook

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #6303: AIRFLOW-5126 Read aws_session_token in extra_config of the aws hook
URL: https://github.com/apache/airflow/pull/6303#discussion_r334192142
 
 

 ##########
 File path: airflow/contrib/hooks/aws_hook.py
 ##########
 @@ -132,7 +134,7 @@ def _get_credentials(self, region_name):
                     role_arn = "arn:aws:iam::{}:role/{}" \
                         .format(aws_account_id, aws_iam_role)
 
-                if role_arn is not None:
+                if role_arn is not None and aws_session_token is None:
 
 Review comment:
   I'm not sure this condition makes sense. What if I want to use key+secret+token to assume a role?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services