[GitHub] [accumulo] ctubbsii commented on a change in pull request #2593: Use ServerContext.getScheduledExecutor where appropriate

[GitBox <gi...@apache.org>]

ctubbsii commented on a change in pull request #2593:
URL: https://github.com/apache/accumulo/pull/2593#discussion_r837695185



##########
File path: server/manager/src/main/java/org/apache/accumulo/manager/ManagerTime.java
##########
@@ -64,6 +64,8 @@ public ManagerTime(Manager manager, AccumuloConfiguration conf) throws IOExcepti
       throw new IOException("Error updating manager time", ex);
     }
 
+    // Previous versions of this class did not use a shared thread pool, it created its own
+    // Timer instance.

Review comment:
       I'm not sure what purpose this comment serves. It's documenting a previous version of the code. It doesn't apply to the code here. If it is needed and kept, it should be reworded to describe the current code and the reason for the current implementation, not reference a previous version that no longer applies.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org