You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pegasus.apache.org by "empiredan (via GitHub)" <gi...@apache.org> on 2023/04/27 13:26:45 UTC
[GitHub] [incubator-pegasus] empiredan opened a new pull request, #1463: feat(new_metrics): migrate metrics for replica_stub (part 4)
empiredan opened a new pull request, #1463:
URL: https://github.com/apache/incubator-pegasus/pull/1463
https://github.com/apache/incubator-pegasus/issues/1454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] empiredan commented on a diff in pull request #1463: feat(new_metrics): migrate metrics for replica_stub (part 4)
Posted by "empiredan (via GitHub)" <gi...@apache.org>.
empiredan commented on code in PR #1463:
URL: https://github.com/apache/incubator-pegasus/pull/1463#discussion_r1185004541
##########
src/replica/replica_stub.cpp:
##########
@@ -2901,7 +2895,7 @@ uint64_t replica_stub::gc_tcmalloc_memory(bool release_all)
release_bytes -= 1024 * 1024;
}
}
- _counter_tcmalloc_release_memory_size->set(tcmalloc_released_bytes);
+ METRIC_VAR_SET(tcmalloc_released_bytes, tcmalloc_released_bytes);
Review Comment:
OK, I'll fix this in the next PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1463: feat(new_metrics): migrate metrics for replica_stub (part 4)
Posted by "acelyc111 (via GitHub)" <gi...@apache.org>.
acelyc111 commented on code in PR #1463:
URL: https://github.com/apache/incubator-pegasus/pull/1463#discussion_r1184958232
##########
src/replica/replica_stub.cpp:
##########
@@ -2901,7 +2895,7 @@ uint64_t replica_stub::gc_tcmalloc_memory(bool release_all)
release_bytes -= 1024 * 1024;
}
}
- _counter_tcmalloc_release_memory_size->set(tcmalloc_released_bytes);
+ METRIC_VAR_SET(tcmalloc_released_bytes, tcmalloc_released_bytes);
Review Comment:
@empiredan As we discuss offline, `tcmalloc_released_bytes` is better to be a counter type, we can improve it in next patch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 commented on a diff in pull request #1463: feat(new_metrics): migrate metrics for replica_stub (part 4)
Posted by "acelyc111 (via GitHub)" <gi...@apache.org>.
acelyc111 commented on code in PR #1463:
URL: https://github.com/apache/incubator-pegasus/pull/1463#discussion_r1181355237
##########
src/replica/duplication/duplication_sync_timer.cpp:
##########
@@ -65,15 +64,13 @@ void duplication_sync_timer::run()
req->node = _stub->primary_address();
// collects confirm points from all primaries on this server
- uint64_t pending_muts_cnt = 0;
for (const replica_ptr &r : get_all_primaries()) {
auto confirmed = r->get_duplication_manager()->get_duplication_confirms_to_update();
if (!confirmed.empty()) {
req->confirm_list[r->get_gpid()] = std::move(confirmed);
}
- pending_muts_cnt += r->get_duplication_manager()->get_pending_mutations_count();
+ METRIC_SET(*(r->get_duplication_manager()), dup_pending_mutations);
Review Comment:
Now that we can get the replica the metric belongs to, why not set the metric via `replica_ptr` directly?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] empiredan commented on a diff in pull request #1463: feat(new_metrics): migrate metrics for replica_stub (part 4)
Posted by "empiredan (via GitHub)" <gi...@apache.org>.
empiredan commented on code in PR #1463:
URL: https://github.com/apache/incubator-pegasus/pull/1463#discussion_r1184736488
##########
src/replica/duplication/duplication_sync_timer.cpp:
##########
@@ -65,15 +64,13 @@ void duplication_sync_timer::run()
req->node = _stub->primary_address();
// collects confirm points from all primaries on this server
- uint64_t pending_muts_cnt = 0;
for (const replica_ptr &r : get_all_primaries()) {
auto confirmed = r->get_duplication_manager()->get_duplication_confirms_to_update();
if (!confirmed.empty()) {
req->confirm_list[r->get_gpid()] = std::move(confirmed);
}
- pending_muts_cnt += r->get_duplication_manager()->get_pending_mutations_count();
+ METRIC_SET(*(r->get_duplication_manager()), dup_pending_mutations);
Review Comment:
OK, I'll add a method for `replica` class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org
[GitHub] [incubator-pegasus] acelyc111 merged pull request #1463: feat(new_metrics): migrate metrics for replica_stub (part 4)
Posted by "acelyc111 (via GitHub)" <gi...@apache.org>.
acelyc111 merged PR #1463:
URL: https://github.com/apache/incubator-pegasus/pull/1463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org