You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Anonymous Coward (Code Review)" <ge...@cloudera.org> on 2019/03/21 23:55:08 UTC
[Impala-ASF-CR] IMPALA-6852: Add a section to the query profile covering number of fragments instances and total bytes scanned per host
fan309@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12831
Change subject: IMPALA-6852: Add a section to the query profile covering number of fragments instances and total bytes scanned per host
......................................................................
IMPALA-6852: Add a section to the query profile covering number of fragments instances and total bytes scanned per host
Query profile is updated to include number of fragment instances per host. Example from "select count (*) from functional.alltypes":
Per Host Number of Fragment Instances: afan-box-7060:22000(2) afan-box-7060:22001(1) afan-box-7060:22002(1)
Change-Id: I9556d7f1d56fd5c68cc2fb60df6f745a74cd4879
---
M be/src/scheduling/scheduler.cc
M tests/query_test/test_observability.py
2 files changed, 13 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/12831/1
--
To view, visit http://gerrit.cloudera.org:8080/12831
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9556d7f1d56fd5c68cc2fb60df6f745a74cd4879
Gerrit-Change-Number: 12831
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <fa...@gmail.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-6852: Add number of fragment instances per host to query profile
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12831 )
Change subject: IMPALA-6852: Add number of fragment instances per host to query profile
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3948/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12831
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9556d7f1d56fd5c68cc2fb60df6f745a74cd4879
Gerrit-Change-Number: 12831
Gerrit-PatchSet: 2
Gerrit-Owner: Alice Fan <fa...@gmail.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Mar 2019 20:52:53 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6852: Add number of fragment instances per host to query profile
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12831 )
Change subject: IMPALA-6852: Add number of fragment instances per host to query profile
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12831
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9556d7f1d56fd5c68cc2fb60df6f745a74cd4879
Gerrit-Change-Number: 12831
Gerrit-PatchSet: 2
Gerrit-Owner: Alice Fan <fa...@gmail.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Sat, 23 Mar 2019 01:30:07 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6852: Add number of fragment instances per host to query profile
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12831 )
Change subject: IMPALA-6852: Add number of fragment instances per host to query profile
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2525/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12831
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9556d7f1d56fd5c68cc2fb60df6f745a74cd4879
Gerrit-Change-Number: 12831
Gerrit-PatchSet: 2
Gerrit-Owner: Alice Fan <fa...@gmail.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Mar 2019 19:33:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6852: Add number of fragment instances per host to query profile
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12831 )
Change subject: IMPALA-6852: Add number of fragment instances per host to query profile
......................................................................
IMPALA-6852: Add number of fragment instances per host to query profile
Query profile is updated to include number of fragment instances
per host. Example from "select count (*) from functional.alltypes":
- Per Host Number of Fragment Instances: afan-box-7060:22000(2)
afan-box-7060:22001(1) afan-box-7060:22002(1)
Added a basic observability test to ensure that the expected section
appears in the query profile.
Change-Id: I9556d7f1d56fd5c68cc2fb60df6f745a74cd4879
Reviewed-on: http://gerrit.cloudera.org:8080/12831
Reviewed-by: Bikramjeet Vig <bi...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/scheduling/scheduler.cc
M tests/query_test/test_observability.py
2 files changed, 14 insertions(+), 0 deletions(-)
Approvals:
Bikramjeet Vig: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12831
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9556d7f1d56fd5c68cc2fb60df6f745a74cd4879
Gerrit-Change-Number: 12831
Gerrit-PatchSet: 3
Gerrit-Owner: Alice Fan <fa...@gmail.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-6852: Add a section to the query profile covering number of fragments instances and total bytes scanned per host
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12831 )
Change subject: IMPALA-6852: Add a section to the query profile covering number of fragments instances and total bytes scanned per host
......................................................................
Patch Set 1:
(3 comments)
looks good, just a few formatting changes
http://gerrit.cloudera.org:8080/#/c/12831/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12831/1//COMMIT_MSG@6
PS1, Line 6:
nit: long lines, should be < 73
http://gerrit.cloudera.org:8080/#/c/12831/1//COMMIT_MSG@7
PS1, Line 7: total bytes scanned
?
http://gerrit.cloudera.org:8080/#/c/12831/1//COMMIT_MSG@12
PS1, Line 12:
nit: add a testing section here briefly explaining what you added or ran
--
To view, visit http://gerrit.cloudera.org:8080/12831
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9556d7f1d56fd5c68cc2fb60df6f745a74cd4879
Gerrit-Change-Number: 12831
Gerrit-PatchSet: 1
Gerrit-Owner: Alice Fan <fa...@gmail.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Mar 2019 17:34:28 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6852: Add a section to the query profile covering number of fragments instances and total bytes scanned per host
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12831 )
Change subject: IMPALA-6852: Add a section to the query profile covering number of fragments instances and total bytes scanned per host
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12831/1/tests/query_test/test_observability.py
File tests/query_test/test_observability.py:
http://gerrit.cloudera.org:8080/#/c/12831/1/tests/query_test/test_observability.py@556
PS1, Line 556: "
flake8: E501 line too long (92 > 90 characters)
--
To view, visit http://gerrit.cloudera.org:8080/12831
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9556d7f1d56fd5c68cc2fb60df6f745a74cd4879
Gerrit-Change-Number: 12831
Gerrit-PatchSet: 1
Gerrit-Owner: Anonymous Coward <fa...@gmail.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 21 Mar 2019 23:55:50 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-6852: Add a section to the query profile covering number of fragments instances and total bytes scanned per host
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12831 )
Change subject: IMPALA-6852: Add a section to the query profile covering number of fragments instances and total bytes scanned per host
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/2517/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12831
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9556d7f1d56fd5c68cc2fb60df6f745a74cd4879
Gerrit-Change-Number: 12831
Gerrit-PatchSet: 1
Gerrit-Owner: Alice Fan <fa...@gmail.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Mar 2019 00:34:28 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6852: Add number of fragment instances per host to query profile
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/12831 )
Change subject: IMPALA-6852: Add number of fragment instances per host to query profile
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12831
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9556d7f1d56fd5c68cc2fb60df6f745a74cd4879
Gerrit-Change-Number: 12831
Gerrit-PatchSet: 2
Gerrit-Owner: Alice Fan <fa...@gmail.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 22 Mar 2019 20:52:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-6852: Add number of fragment instances per host to query profile
Posted by "Alice Fan (Code Review)" <ge...@cloudera.org>.
Hello Bikramjeet Vig, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12831
to look at the new patch set (#2).
Change subject: IMPALA-6852: Add number of fragment instances per host to query profile
......................................................................
IMPALA-6852: Add number of fragment instances per host to query profile
Query profile is updated to include number of fragment instances
per host. Example from "select count (*) from functional.alltypes":
- Per Host Number of Fragment Instances: afan-box-7060:22000(2)
afan-box-7060:22001(1) afan-box-7060:22002(1)
Added a basic observability test to ensure that the expected section
appears in the query profile.
Change-Id: I9556d7f1d56fd5c68cc2fb60df6f745a74cd4879
---
M be/src/scheduling/scheduler.cc
M tests/query_test/test_observability.py
2 files changed, 14 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/31/12831/2
--
To view, visit http://gerrit.cloudera.org:8080/12831
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9556d7f1d56fd5c68cc2fb60df6f745a74cd4879
Gerrit-Change-Number: 12831
Gerrit-PatchSet: 2
Gerrit-Owner: Alice Fan <fa...@gmail.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>