You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2013/11/07 13:14:31 UTC
[jira] [Commented] (HELIX-234) Create concrete id classes for constructs, replacing strings

    [ https://issues.apache.org/jira/browse/HELIX-234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13815887#comment-13815887 ] 

Hudson commented on HELIX-234:
------------------------------

FAILURE: Integrated in helix #1202 (See [https://builds.apache.org/job/helix/1202/])
[HELIX-234] Convert-all-Id.x-to-x.from-and-assorted-code-cleanup (kanak: rev fb96a13826271bd02ae42e87873c178f6c1f3612)
* helix-core/src/main/java/org/apache/helix/josql/ClusterJosqlQueryProcessor.java
* helix-core/src/main/java/org/apache/helix/controller/restlet/ZNRecordUpdateResource.java
* helix-core/src/main/java/org/apache/helix/alerts/Tuple.java
* helix-core/src/main/java/org/apache/helix/api/ResourceAccessor.java
* helix-core/src/main/java/org/apache/helix/controller/rebalancer/CustomRebalancer.java
* helix-core/src/test/java/org/apache/helix/manager/zk/TestZkHelixAdmin.java
* helix-core/src/main/java/org/apache/helix/controller/strategy/RUSHrHash.java
* helix-core/src/main/java/org/apache/helix/messaging/handling/HelixStateTransitionHandler.java
* helix-core/src/main/java/org/apache/helix/model/builder/AutoRebalanceModeISBuilder.java
* helix-core/src/main/java/org/apache/helix/api/ParticipantAccessor.java
* helix-core/src/test/java/org/apache/helix/util/TestZKClientPool.java
* helix-core/src/test/java/org/apache/helix/mock/controller/MockController.java
* helix-core/src/main/java/org/apache/helix/healthcheck/DecayAggregationType.java
* helix-core/src/main/java/org/apache/helix/healthcheck/PerformanceHealthReportProvider.java
* helix-core/src/test/java/org/apache/helix/api/TestNewStages.java
* helix-core/src/test/java/org/apache/helix/integration/TestMessageThrottle.java
* helix-core/src/test/java/org/apache/helix/participant/TestDistControllerStateModel.java
* helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ResourceMonitor.java
* helix-core/src/test/java/org/apache/helix/TestZNRecord.java
* helix-core/src/test/java/org/apache/helix/manager/zk/TestZKPropertyTransferServer.java
* helix-core/src/test/java/org/apache/helix/manager/zk/TestWtCacheSyncOpSingleThread.java
* helix-core/src/test/java/org/apache/helix/monitoring/mbeans/TestResourceMonitor.java
* helix-core/src/test/java/org/apache/helix/manager/zk/TestZkCacheSyncOpSingleThread.java
* helix-core/src/test/java/org/apache/helix/controller/strategy/TestNewAutoRebalanceStrategy.java
* helix-core/src/main/java/org/apache/helix/api/StateModelFactoryId.java
* helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java
* helix-core/src/main/java/org/apache/helix/model/PartitionConfiguration.java
* helix-core/src/test/java/org/apache/helix/healthcheck/TestExpandAlert.java
* helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java
* helix-core/src/main/java/org/apache/helix/api/ResourceConfig.java
* helix-core/src/test/java/org/apache/helix/monitoring/TestStatCollector.java
* helix-core/src/test/java/org/apache/helix/alerts/TestAddPersistentStats.java
* helix-examples/src/main/java/org/apache/helix/examples/BootstrapHandler.java
* helix-core/src/test/java/org/apache/helix/integration/TestStandAloneCMSessionExpiry.java
* helix-core/src/main/java/org/apache/helix/ConfigAccessor.java
* helix-core/src/main/java/org/apache/helix/api/SpectatorId.java
* helix-core/src/main/java/org/apache/helix/util/StatusUpdateUtil.java
* helix-core/src/test/java/org/apache/helix/integration/TestDistributedClusterController.java
* helix-core/src/test/java/org/apache/helix/integration/TestEnablePartitionDuringDisable.java
* recipes/rsync-replicated-file-system/src/main/java/org/apache/helix/filestore/ChangeLogReader.java
* helix-agent/src/test/java/org/apache/helix/agent/TestHelixAgent.java
* helix-core/src/main/java/org/apache/helix/util/ZKClientPool.java
* helix-core/src/main/java/org/apache/helix/api/NamespacedConfig.java
* helix-core/src/main/java/org/apache/helix/model/ResourceConfiguration.java
* helix-core/src/test/java/org/apache/helix/integration/TestZkCallbackHandlerLeak.java
* helix-core/src/main/java/org/apache/helix/api/ProcId.java
* helix-core/src/main/java/org/apache/helix/api/StateModelDefinitionAccessor.java
* helix-core/src/test/java/org/apache/helix/messaging/handling/TestResourceThreadpoolSize.java
* helix-core/src/main/java/org/apache/helix/api/StateModelDefId.java
* helix-core/src/main/java/org/apache/helix/alerts/ExpressionParser.java
* helix-core/src/test/java/org/apache/helix/mock/controller/MockControllerProcess.java
* helix-core/src/main/java/org/apache/helix/messaging/handling/BatchMessageHandler.java
* helix-core/src/main/java/org/apache/helix/api/Resource.java
* helix-core/src/test/java/org/apache/helix/controller/stages/TestMessageThrottleStage.java
* helix-core/src/main/java/org/apache/helix/healthcheck/Stat.java
* helix-core/src/main/java/org/apache/helix/monitoring/mbeans/ClusterMBeanObserver.java
* helix-core/src/test/java/org/apache/helix/ZkTestHelper.java
* helix-core/src/test/java/org/apache/helix/manager/zk/TestWtCacheAsyncOpMultiThread.java
* helix-core/src/main/java/org/apache/helix/controller/stages/StatsAggregationStage.java
* helix-core/src/main/java/org/apache/helix/model/ExternalView.java
* helix-core/src/main/java/org/apache/helix/controller/rebalancer/AutoRebalancer.java
* helix-core/src/main/java/org/apache/helix/controller/stages/MessageThrottleStage.java
* helix-core/src/test/java/org/apache/helix/integration/ZkIntegrationTestBase.java
* helix-core/src/test/java/org/apache/helix/alerts/TestBaseStatsValidation.java
* helix-core/src/main/java/org/apache/helix/model/ResourceAssignment.java
* helix-core/src/test/java/org/apache/helix/integration/TestAddStateModelFactoryAfterConnect.java
* helix-core/src/test/java/org/apache/helix/integration/TestSchedulerMsgContraints.java
* helix-core/src/main/java/org/apache/helix/participant/statemachine/StateModelFactory.java
* helix-core/src/main/java/org/apache/helix/controller/rebalancer/NewAutoRebalancer.java
* helix-core/src/test/java/org/apache/helix/Mocks.java
* helix-core/src/main/java/org/apache/helix/monitoring/mbeans/StateTransitionStatMonitor.java
* helix-core/src/test/java/org/apache/helix/controller/stages/TestBestPossibleCalcStageCompatibility.java
* helix-core/src/main/java/org/apache/helix/controller/stages/HealthDataCache.java
* helix-core/src/main/java/org/apache/helix/manager/zk/AbstractManager.java
* helix-core/src/test/java/org/apache/helix/integration/TestDrop.java
* helix-core/src/test/java/org/apache/helix/messaging/TestAsyncCallbackSvc.java
* helix-core/src/test/java/org/apache/helix/alerts/TestAlertValidation.java
* helix-core/src/test/java/org/apache/helix/manager/zk/TestZkStateChangeListener.java
* helix-core/src/main/java/org/apache/helix/api/ClusterId.java
* helix-core/src/test/java/org/apache/helix/integration/TestDistributedCMMain.java
* helix-core/src/test/java/org/apache/helix/integration/TestParticipantErrorMessage.java
* helix-core/src/main/java/org/apache/helix/alerts/StatsHolder.java
* helix-core/src/test/java/org/apache/helix/healthcheck/TestSimpleAlert.java
* helix-core/src/test/java/org/apache/helix/controller/stages/TestRebalancePipeline.java
* recipes/rsync-replicated-file-system/src/main/java/org/apache/helix/filestore/ChangeLogGenerator.java
* helix-core/src/test/java/org/apache/helix/model/TestConstraint.java
* helix-core/src/main/java/org/apache/helix/api/SessionId.java
* helix-core/src/main/java/org/apache/helix/messaging/DefaultMessagingService.java
* helix-core/src/main/java/org/apache/helix/controller/stages/NewTaskAssignmentStage.java
* helix-core/src/test/java/org/apache/helix/participant/TestDistControllerElection.java
* helix-core/src/main/java/org/apache/helix/model/Message.java
* helix-core/src/main/java/org/apache/helix/manager/zk/ZkClient.java
* helix-core/src/main/java/org/apache/helix/api/RebalancerRef.java
* helix-core/src/test/java/org/apache/helix/integration/TestExternalViewUpdates.java
* helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManager.java
* helix-core/src/test/java/org/apache/helix/integration/TestMessagingService.java
* helix-core/src/test/java/org/apache/helix/integration/TestMessagePartitionStateMismatch.java
* helix-core/src/test/java/org/apache/helix/model/TestIdealState.java
* helix-core/src/main/java/org/apache/helix/api/RebalancerConfig.java
* helix-core/src/test/java/org/apache/helix/manager/zk/TestZKLiveInstanceData.java
* helix-core/src/main/java/org/apache/helix/HelixAdmin.java
* helix-core/src/test/java/org/apache/helix/alerts/TestEvaluateAlerts.java
* helix-core/src/main/java/org/apache/helix/healthcheck/StatHealthReportProvider.java
* helix-core/src/main/java/org/apache/helix/api/PartitionId.java
* helix-core/src/main/java/org/apache/helix/controller/rebalancer/SemiAutoRebalancer.java
* helix-core/src/main/java/org/apache/helix/manager/zk/ZkBaseDataAccessor.java
* helix-core/src/test/java/org/apache/helix/healthcheck/TestAlertActionTriggering.java
* helix-core/src/test/java/org/apache/helix/healthcheck/TestWildcardAlert.java
* helix-core/src/main/java/org/apache/helix/alerts/AlertsHolder.java
* helix-core/src/test/java/org/apache/helix/TestZKCallback.java
* helix-core/src/main/java/org/apache/helix/participant/HelixStateMachineEngine.java
* helix-core/src/test/java/org/apache/helix/controller/stages/TestMsgSelectionStage.java
* helix-core/src/test/java/org/apache/helix/monitoring/TestParticipantMonitor.java
* helix-core/src/main/java/org/apache/helix/manager/zk/serializer/JacksonPayloadSerializer.java
* helix-core/src/test/java/org/apache/helix/controller/strategy/TestAutoRebalanceStrategy.java
* helix-core/src/test/java/org/apache/helix/TestZnodeModify.java
* helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/SchedulerTasksResource.java
* helix-core/src/main/java/org/apache/helix/model/LiveInstance.java
* helix-core/src/main/java/org/apache/helix/tools/MessagePoster.java
* helix-core/src/main/java/org/apache/helix/tools/CLMLogFileAppender.java
* helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java
* helix-core/src/test/java/org/apache/helix/TestZKRoutingInfoProvider.java
* helix-core/src/main/java/org/apache/helix/model/InstanceConfig.java
* helix-core/src/main/java/org/apache/helix/model/ClusterConfiguration.java
* helix-core/src/test/java/org/apache/helix/integration/TestAutoRebalancePartitionLimit.java
* helix-core/src/main/java/org/apache/helix/api/UserConfig.java
* helix-core/src/test/java/org/apache/helix/TestZNRecordBucketizer.java
* helix-core/src/test/java/org/apache/helix/integration/TestFailOverPerf1kp.java
* helix-examples/src/main/java/org/apache/helix/examples/BootstrapProcess.java
* helix-core/src/test/java/org/apache/helix/healthcheck/TestAlertFireHistory.java
* helix-examples/src/main/java/org/apache/helix/examples/MasterSlaveStateModelFactory.java
* helix-core/src/main/java/org/apache/helix/model/IdealState.java
* helix-examples/src/main/java/org/apache/helix/examples/NewModelExample.java
* helix-core/src/test/java/org/apache/helix/participant/TestDistControllerStateModelFactory.java
* helix-core/src/test/java/org/apache/helix/integration/manager/TestConsecutiveZkSessionExpiry.java
* helix-core/src/main/java/org/apache/helix/alerts/AlertProcessor.java
* helix-core/src/main/java/org/apache/helix/model/StateModelDefinition.java
* helix-core/src/test/java/org/apache/helix/TestHelixConfigAccessor.java
* helix-core/src/test/java/org/apache/helix/TestGroupCommit.java
* helix-core/src/test/java/org/apache/helix/messaging/TestDefaultMessagingService.java
* helix-core/src/main/java/org/apache/helix/monitoring/ZKPathDataDumpTask.java
* helix-core/src/test/java/org/apache/helix/controller/stages/TestParseInfoFromAlert.java
* helix-core/src/test/java/org/apache/helix/api/TestId.java
* helix-core/src/main/java/org/apache/helix/api/ParticipantId.java
* helix-core/src/test/java/org/apache/helix/integration/TestDisable.java
* helix-core/src/main/java/org/apache/helix/manager/zk/ZkCacheBaseDataAccessor.java
* helix-core/src/test/java/org/apache/helix/integration/TestErrorPartition.java
* helix-core/src/test/java/org/apache/helix/integration/TestSwapInstance.java
* helix-core/src/main/java/org/apache/helix/PropertyPathConfig.java
* helix-core/src/test/java/org/apache/helix/messaging/handling/TestHelixTaskExecutor.java
* helix-core/src/test/java/org/apache/helix/integration/TestBatchMessage.java
* helix-core/src/test/java/org/apache/helix/integration/TestBucketizedResource.java
* recipes/rsync-replicated-file-system/src/main/java/org/apache/helix/filestore/Test.java
* helix-core/src/main/java/org/apache/helix/participant/HelixCustomCodeRunner.java
* helix-core/src/main/java/org/apache/helix/api/ResourceId.java
* helix-core/src/test/java/org/apache/helix/manager/zk/TestZkCacheAsyncOpSingleThread.java
* helix-core/src/test/java/org/apache/helix/manager/zk/TestLiveInstanceBounce.java
* helix-core/src/test/java/org/apache/helix/integration/TestZkReconnect.java
* helix-core/src/test/java/org/apache/helix/manager/zk/TestDefaultControllerMsgHandlerFactory.java
* helix-core/src/main/java/org/apache/helix/manager/zk/WriteThroughCache.java
* helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ZkPathResource.java
* helix-core/src/test/java/org/apache/helix/api/TestNamespacedConfig.java
* helix-core/src/test/java/org/apache/helix/alerts/TestArrivingParticipantStats.java
* recipes/service-discovery/src/main/java/org/apache/helix/servicediscovery/ServiceDiscovery.java
* helix-core/src/main/java/org/apache/helix/api/MessageId.java
* helix-core/src/main/java/org/apache/helix/api/ParticipantConfig.java
* helix-core/src/main/java/org/apache/helix/tools/ClusterStateVerifier.java
* helix-core/src/test/java/org/apache/helix/manager/zk/TestWtCacheAsyncOpSingleThread.java
* helix-core/src/main/java/org/apache/helix/manager/zk/ControllerManagerHelper.java
* helix-core/src/main/java/org/apache/helix/api/ClusterAccessor.java
* helix-core/src/test/java/org/apache/helix/TestZkBasis.java
* helix-core/src/test/java/org/apache/helix/controller/stages/TestResourceComputationStage.java
* helix-core/src/test/java/org/apache/helix/integration/TestHelixCustomCodeRunner.java
* helix-core/src/test/java/org/apache/helix/store/TestJsonComparator.java
* helix-core/src/test/java/org/apache/helix/integration/TestSchedulerMsgUsingQueue.java
* helix-agent/src/main/java/org/apache/helix/agent/ProcessMonitorThread.java
* helix-core/src/main/java/org/apache/helix/controller/stages/BestPossibleStateCalcStage.java
* helix-core/src/test/java/org/apache/helix/integration/TestNonOfflineInitState.java
* helix-core/src/main/java/org/apache/helix/model/builder/CustomModeISBuilder.java
* helix-core/src/main/java/org/apache/helix/participant/GenericLeaderStandbyModel.java
* helix-core/src/test/java/org/apache/helix/TestHelper.java
* helix-core/src/main/java/org/apache/helix/healthcheck/DefaultHealthReportProvider.java
* helix-core/src/test/java/org/apache/helix/integration/TestInvalidAutoIdealState.java
* helix-core/src/test/java/org/apache/helix/integration/TestResetInstance.java
* helix-core/src/main/java/org/apache/helix/controller/stages/MessageGenerationPhase.java
* helix-core/src/main/java/org/apache/helix/controller/stages/NewResourceComputationStage.java
* helix-core/src/main/java/org/apache/helix/healthcheck/ParticipantHealthReportCollectorImpl.java
* helix-core/src/test/java/org/apache/helix/messaging/TestAsyncCallback.java
* helix-examples/src/main/java/org/apache/helix/examples/IdealStateExample.java
* helix-core/src/main/java/org/apache/helix/manager/zk/HelixGroupCommit.java
* helix-core/src/test/java/org/apache/helix/TestPerformanceHealthReportProvider.java
* helix-core/src/test/java/org/apache/helix/TestZkClientWrapper.java
* helix-core/src/test/java/org/apache/helix/alerts/TestOperators.java
* helix-examples/src/main/java/org/apache/helix/examples/ExampleProcess.java
* helix-core/src/test/java/org/apache/helix/TestHelixTaskHandler.java
* helix-core/src/test/java/org/apache/helix/alerts/TestAddAlerts.java
* helix-core/src/test/java/org/apache/helix/TestConfigAccessor.java
* helix-core/src/main/java/org/apache/helix/controller/stages/ExternalViewComputeStage.java
* helix-core/src/main/java/org/apache/helix/api/Scope.java
* helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java
* helix-core/src/test/java/org/apache/helix/healthcheck/TestStalenessAlert.java
* helix-examples/src/main/java/org/apache/helix/examples/Quickstart.java
* helix-core/src/test/java/org/apache/helix/integration/TestAddNodeAfterControllerStart.java
* helix-core/src/test/java/org/apache/helix/mock/participant/MockParticipant.java
* helix-core/src/main/java/org/apache/helix/manager/zk/CurStateCarryOverUpdater.java
* helix-core/src/test/java/org/apache/helix/messaging/handling/TestConfigThreadpoolSize.java
* helix-core/src/main/java/org/apache/helix/alerts/WindowAggregator.java
* helix-core/src/test/java/org/apache/helix/TestHierarchicalDataStore.java
* helix-core/src/main/java/org/apache/helix/api/ControllerId.java
* helix-core/src/main/java/org/apache/helix/controller/stages/NewMessageGenerationStage.java
* helix-core/src/main/java/org/apache/helix/controller/stages/NewExternalViewComputeStage.java
* helix-core/src/test/java/org/apache/helix/controller/stages/BaseStageTest.java
* helix-core/src/test/java/org/apache/helix/integration/TestAddClusterV2.java
* helix-core/src/test/java/org/apache/helix/integration/TestResetResource.java
* helix-core/src/main/java/org/apache/helix/manager/zk/DefaultSchedulerMessageHandlerFactory.java
* helix-core/src/main/java/org/apache/helix/model/CurrentState.java
* helix-core/src/test/java/org/apache/helix/healthcheck/TestSimpleWildcardAlert.java
* helix-admin-webapp/src/main/java/org/apache/helix/webapp/resources/ConfigResource.java
* helix-core/src/test/java/org/apache/helix/healthcheck/TestDummyAlerts.java
* helix-core/src/main/java/org/apache/helix/controller/strategy/AutoRebalanceStrategy.java
* helix-core/src/main/java/org/apache/helix/messaging/handling/MessageHandler.java
* helix-core/src/main/java/org/apache/helix/manager/zk/Cache.java
* helix-core/src/main/java/org/apache/helix/model/builder/ConstraintItemBuilder.java
* helix-core/src/test/java/org/apache/helix/controller/stages/TestBestPossibleStateCalcStage.java
* helix-core/src/main/java/org/apache/helix/controller/ExternalViewGenerator.java
* helix-core/src/main/java/org/apache/helix/manager/zk/ControllerManager.java
* helix-core/src/main/java/org/apache/helix/api/ClusterConfig.java
* helix-core/src/main/java/org/apache/helix/api/Id.java
* helix-core/src/test/java/org/apache/helix/alerts/TestStatsMatch.java
* helix-core/src/test/java/org/apache/helix/TestHelixTaskExecutor.java
* helix-core/src/test/java/org/apache/helix/mock/participant/MockMSModelFactory.java
* helix-core/src/test/java/org/apache/helix/store/zk/TestZkHelixPropertyStore.java
* helix-core/src/main/java/org/apache/helix/messaging/handling/AsyncCallbackService.java
* helix-core/src/test/java/org/apache/helix/manager/zk/TestZkBaseDataAccessor.java
* helix-core/src/main/java/org/apache/helix/controller/stages/NewReadClusterDataStage.java
* helix-core/src/test/java/org/apache/helix/josql/TestJosqlProcessor.java
* helix-core/src/main/java/org/apache/helix/model/builder/AutoModeISBuilder.java
* helix-core/src/test/java/org/apache/helix/manager/zk/TestHandleNewSession.java
* helix-core/src/test/java/org/apache/helix/healthcheck/TestAddDropAlert.java
* helix-core/src/test/java/org/apache/helix/manager/zk/TestZNRecordSizeLimit.java
* recipes/rsync-replicated-file-system/src/main/java/org/apache/helix/filestore/ChangeLogProcessor.java
* helix-core/src/main/java/org/apache/helix/manager/zk/ZkCallbackCache.java
* helix-core/src/test/java/org/apache/helix/integration/TestSchedulerMessage.java
* helix-core/src/test/java/org/apache/helix/monitoring/mbeans/TestClusterAlertItemMBeanCollection.java
* helix-core/src/main/java/org/apache/helix/alerts/DecayAggregator.java
* helix-core/src/test/java/org/apache/helix/mock/controller/ClusterController.java
* helix-core/src/test/java/org/apache/helix/tools/TestClusterSetup.java
* helix-core/src/main/java/org/apache/helix/controller/restlet/ZKPropertyTransferServer.java
* helix-core/src/test/java/org/apache/helix/controller/stages/TestCurrentStateComputationStage.java
* helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java
* recipes/rsync-replicated-file-system/src/main/java/org/apache/helix/filestore/FileStore.java


> Create concrete id classes for constructs, replacing strings
> ------------------------------------------------------------
>
>                 Key: HELIX-234
>                 URL: https://issues.apache.org/jira/browse/HELIX-234
>             Project: Apache Helix
>          Issue Type: Sub-task
>          Components: helix-core, helix-webapp-admin
>            Reporter: Kanak Biscuitwala
>            Assignee: Kanak Biscuitwala
>             Fix For: 0.6.2-incubating
>
>
> cluster, resource, participant, partition, state model, and others should not be identified by strings



--
This message was sent by Atlassian JIRA
(v6.1#6144)