[jira] [Commented] (FLINK-9152) Harmonize BroadcastProcessFunction Context names

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-9152?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16431481#comment-16431481 ] 

ASF GitHub Bot commented on FLINK-9152:
---------------------------------------

GitHub user aljoscha opened a pull request:

    https://github.com/apache/flink/pull/5830

    [FLINK-9152] Harmonize BroadcastProcessFunction Context names

    R: @kl0u 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aljoscha/flink jira-9152-harmonize-broadcast-connect

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5830.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5830
    
----
commit 8866c314e79c09c2093b2863d56787435f5d0fb5
Author: Aljoscha Krettek <al...@...>
Date:   2018-04-09T23:08:58Z

    [FLINK-9152] Harmonize BroadcastProcessFunction Context names

commit 6af7b661ddf41022d7fa25a36c8fa5c21096ef1e
Author: Aljoscha Krettek <al...@...>
Date:   2018-04-09T23:12:43Z

    [FLINK-9252] Use in-class Context objects in BroadcastProcessFunction
    
    This brings it in line with KeyedBroadcastProcessFunction, which uses
    context objects defined in KeyedBroadcastProcessFunction. The context
    objects here have no added functionality but we still define them here
    so that the methods don't refer to the base class implementations for
    consistency.

----


> Harmonize BroadcastProcessFunction Context names
> ------------------------------------------------
>
>                 Key: FLINK-9152
>                 URL: https://issues.apache.org/jira/browse/FLINK-9152
>             Project: Flink
>          Issue Type: Improvement
>          Components: DataStream API
>    Affects Versions: 1.5.0
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>            Priority: Blocker
>             Fix For: 1.5.0
>
>
> Currently, the {{Context}} on {{KeyedBroadcastProcessFunction}} is called {{KeyedContext}}, which is different from the name of the context on {{BroadcastProcessFunction}}. This leads to the strange combination of
> {code:java}
> public abstract void processBroadcastElement(final IN2 value, final KeyedContext ctx, final Collector<OUT> out) throws Exception;
> {code}
> i.e. you're processing a broadcast element but the context is called a "keyed" context.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)