[GitHub] [celix] PengZheng commented on pull request #494: Remove buffer mechanism from websocket pubsub admin, make similar to tcp admin

["PengZheng (via GitHub)" <gi...@apache.org>]

PengZheng commented on PR #494:
URL: https://github.com/apache/celix/pull/494#issuecomment-1458039221

   > I think the `psa_websocket_recvThread` is not needed anymore, because received data is provided through civetweb to the `psa_websocketTopicReceiver_data`.
   > So IMO the `psa_websocket_recvThread` can be removed if the `psa_websocketTopicReceiver_data` function also checks the allConnected and allInitialized.
   
   What if `mg_connect_websocket_client` could block arbitrarily long? Then data processing will be blocked, which makes thread priority adjustment completely meaningless.
   
   >  so that subscriber providers can tweak thread prio for receiving data.
   
   RSA over http also has this problem, while RSA over shm does not (we have our own thread pool).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org