You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2010/05/14 16:52:27 UTC
DO NOT REPLY [Bug 49292] New: Memory leak in
org.apache.taglibs.standard.lang.jstl.ELEvaluator
https://issues.apache.org/bugzilla/show_bug.cgi?id=49292
Summary: Memory leak in
org.apache.taglibs.standard.lang.jstl.ELEvaluator
Product: Taglibs
Version: 1.1
Platform: PC
OS/Version: Windows Server 2003
Status: NEW
Severity: normal
Priority: P2
Component: Standard Taglib
AssignedTo: dev@tomcat.apache.org
ReportedBy: pmd1nh-rm@yahoo.com
Created an attachment (id=25438)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=25438)
Snapshot shows large entries in the Map
Hi,
I got an OOM and Eclipse MAT shows a potential leak in the
org.apache.taglibs.standard.lang.jstl.ELEvaluator.
There was a memory leak in this area and fixed via revision 580198 (Bug 31789
http://issues.apache.org/bugzilla/show_bug.cgi?id=31789). This fix has already
been pulled into our standard.jar bundle.
I use the default exprCacheSize which is 100. So the LRUMap size would be
expected to be max out at 100. However, the heapdump during the OOM shows that
there was 1.8 million entries in the map (screenshot is attached).
Is there any potential or known issue in this LRUMap?
Thanks,
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 49292] Memory leak in
org.apache.taglibs.standard.lang.jstl.ELEvaluator
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49292
--- Comment #10 from pmd1nh-rm@yahoo.com 2010-06-29 10:47:28 EDT ---
Hi,
User's app overwrites our jar and causes this issue.
Please close down this thread. Thank you very much for your help!
Regards,
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 49292] Memory leak in
org.apache.taglibs.standard.lang.jstl.ELEvaluator
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49292
--- Comment #7 from pmd1nh-rm@yahoo.com 2010-05-20 13:10:05 EDT ---
Hi,
Can you please share the application/JSP source that you used to test this? I
don't have a test case for this as the dump was sent in by one of our
customers.
Thank you for your help!
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 49292] Memory leak in
org.apache.taglibs.standard.lang.jstl.ELEvaluator
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49292
--- Comment #5 from nebur43 <ru...@gmail.com> 2010-05-20 05:35:34 EDT ---
Hi again,
I just have tested the jar and seems to work correctly.
Sorry, but your jar seems not to be correctly. In your first snapshot you can
see these:
- ELEvaluator
- Colletions
-HashMap
-.... lots of HashMap
In my snapshot I attach today, yo can see:
- ELEvaluator
- Colletions
-LRUMap
- AbstractHasedMap
- 79 AbstractLinkedMap
So you are using the old ELEvaluator. Be sure your ELEvaluator are in:
org\apache\taglibs\standard\lang\jstl
and not in:
standard\lang\jstl
Or if you prefer, test my jar file.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 49292] Memory leak in
org.apache.taglibs.standard.lang.jstl.ELEvaluator
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49292
--- Comment #1 from nebur43 <ru...@gmail.com> 2010-05-19 11:27:00 EDT ---
Hi,
Are you sure apply correctly the patch? These patch is must be apply not in
root path, also in \src\org\apache\taglibs\standard.
And extra/collections package must be move to extra\commons\collections before
running ant. (the patch is a little confusing).
Could you attach a memory snapshot for all direct ELEvaluator childrens?
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 49292] Memory leak in
org.apache.taglibs.standard.lang.jstl.ELEvaluator
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49292
Jeremy Boynes <jb...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution| |INVALID
--- Comment #11 from Jeremy Boynes <jb...@apache.org> 2010-10-11 22:58:22 EDT ---
Resolving as per comment 10 this appears to be a user issue
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 49292] Memory leak in
org.apache.taglibs.standard.lang.jstl.ELEvaluator
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49292
--- Comment #6 from nebur43 <ru...@gmail.com> 2010-05-20 05:38:46 EDT ---
Created an attachment (id=25461)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=25461)
snapshot new ELEvaluator
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 49292] Memory leak in
org.apache.taglibs.standard.lang.jstl.ELEvaluator
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49292
--- Comment #3 from pmd1nh-rm@yahoo.com 2010-05-19 16:26:08 EDT ---
Created an attachment (id=25458)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=25458)
snapshot of ELEvaluator direct children
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 49292] Memory leak in
org.apache.taglibs.standard.lang.jstl.ELEvaluator
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49292
--- Comment #4 from pmd1nh-rm@yahoo.com 2010-05-19 16:27:28 EDT ---
Hi,
Yes, I'm sure that the patch has been applied correctly. I have also
downloaded your attachment of standard-1.0.6, decompiled, and compared with
ours. They are same (from the main fixes in lang.jstl.ELEvaluator and
Evaluator to the extra files in extra.commons.collections.*). I attached the
snapshot of ELEvaluator's direct children
Thanks!
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 49292] Memory leak in
org.apache.taglibs.standard.lang.jstl.ELEvaluator
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49292
--- Comment #8 from nebur43 <ru...@gmail.com> 2010-05-21 05:31:15 EDT ---
Sorry, I dont have any test case. I tested it in our aplication.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 49292] Memory leak in
org.apache.taglibs.standard.lang.jstl.ELEvaluator
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49292
--- Comment #2 from nebur43 <ru...@gmail.com> 2010-05-19 11:35:08 EDT ---
Created an attachment (id=25456)
--> (https://issues.apache.org/bugzilla/attachment.cgi?id=25456)
standard.1.0.6 patched for j2se 1.4
Attached the standard.jar with the patch
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
DO NOT REPLY [Bug 49292] Memory leak in
org.apache.taglibs.standard.lang.jstl.ELEvaluator
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49292
--- Comment #9 from Henri Yandell <ba...@apache.org> 2010-06-29 03:44:14 EDT ---
Noting that we just dropped the LRUMap code in trunk and replaced it with a JDK
1.5 class (LinkedHashMap).
Looking at the comments, it looks as though the issue was resolved as a
no-issue? Patch not applied on jar?
If still an issue, retrying with trunk (JSTL 1.2) would be valuable. Let me
know if you need a build uploaded.
--
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org