You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/03/10 09:24:53 UTC

[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #3952: vrouter: remove a POSTROUTING rule for port forwarding in VPC router

DaanHoogland commented on a change in pull request #3952: vrouter: remove a POSTROUTING rule for port forwarding in VPC router
URL: https://github.com/apache/cloudstack/pull/3952#discussion_r390183744
 
 

 ##########
 File path: systemvm/debian/opt/cloud/bin/configure.py
 ##########
 @@ -918,15 +918,6 @@ def forward_vpc(self, rule):
         if not rule["internal_ports"] == "any":
             fw_prerout_rule += ":" + self.portsToString(rule["internal_ports"], "-")
 
-        fw_postrout_rule = "-A POSTROUTING -d %s/32 " % rule["public_ip"]
 
 Review comment:
   pylint error: no longer defined but still used in 942

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services