You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Prasad Mujumdar <pr...@cloudera.com> on 2011/10/21 01:03:10 UTC

Review Request: Hive-727 : Add a schema for explain statement resultset

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2517/
-----------------------------------------------------------

Review request for hive and Carl Steinbach.


Summary
-------

Added a method to get result schema from a Task. The ExplainSemanticAnalyzer invokes this to get the schema for explain statement which is a single string column.


This addresses bug Hive-727.
    https://issues.apache.org/jira/browse/Hive-727


Diffs
-----

  jdbc/src/test/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java 4972754 
  ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java fe95cb1 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java 41d2a81 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ExplainSemanticAnalyzer.java fc22535 

Diff: https://reviews.apache.org/r/2517/diff


Testing
-------

Added  a new test case in TestJdbcDriver to run  explain statement and verify resultset metadata 


Thanks,

Prasad

Re: Review Request: Hive-727 : Add a schema for explain statement resultset

Posted by Prasad Mujumdar <pr...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2517/
-----------------------------------------------------------

(Updated 2011-12-14 23:21:30.477384)


Review request for hive and Carl Steinbach.


Changes
-------

Rebased the patch and reran the TestJdbcDriver test.


Summary
-------

Added a method to get result schema from a Task. The ExplainSemanticAnalyzer invokes this to get the schema for explain statement which is a single string column.


This addresses bug Hive-727.
    https://issues.apache.org/jira/browse/Hive-727


Diffs (updated)
-----

  jdbc/src/test/org/apache/hadoop/hive/jdbc/TestJdbcDriver.java 4972754 
  ql/src/java/org/apache/hadoop/hive/ql/exec/ExplainTask.java 7e5f645 
  ql/src/java/org/apache/hadoop/hive/ql/exec/Task.java a4e59ca 
  ql/src/java/org/apache/hadoop/hive/ql/parse/ExplainSemanticAnalyzer.java 9dc6f87 

Diff: https://reviews.apache.org/r/2517/diff


Testing
-------

Added  a new test case in TestJdbcDriver to run  explain statement and verify resultset metadata 


Thanks,

Prasad