You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@spark.apache.org by "Juliusz Sompolski (JIRA)" <ji...@apache.org> on 2017/09/22 15:06:00 UTC
[jira] [Created] (SPARK-22103) Move HashAggregateExec parent
consume to a separate function in codegen
Juliusz Sompolski created SPARK-22103:
-----------------------------------------
Summary: Move HashAggregateExec parent consume to a separate function in codegen
Key: SPARK-22103
URL: https://issues.apache.org/jira/browse/SPARK-22103
Project: Spark
Issue Type: Improvement
Components: SQL
Affects Versions: 2.3.0
Reporter: Juliusz Sompolski
HashAggregateExec codegen uses two paths for fast hash table and a generic one.
It generates code paths for iterating over both, and both code paths generate the consume code of the parent operator, resulting in that code being expanded twice.
This leads to a long generated function that might be an issue for the compiler (see e.g. SPARK-21603).
I propose to remove the double expansion by generating the consume code in a helper function that can just be called from both iterating loop.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@spark.apache.org
For additional commands, e-mail: issues-help@spark.apache.org