You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/02/04 17:39:44 UTC
[GitHub] [superset] etr2460 opened a new pull request #12950: chore: rename revision to match naming scheme
etr2460 opened a new pull request #12950:
URL: https://github.com/apache/superset/pull/12950
### SUMMARY
When creating a new migration, I was confused because the `down_revision` didn't match any of the migration files that existed. Turned out the revision hash didn't match the filename for this migration, so i'm renaming the file to match. This _should_ be a safe change since the revision number is remaining the same, only the file name is changing.
### TEST PLAN
CI
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
to: @amitmiran137 @john-bodley @dpgaspar @villebro
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #12950: chore: rename revision to match naming scheme
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12950:
URL: https://github.com/apache/superset/pull/12950#issuecomment-773526756
# [Codecov](https://codecov.io/gh/apache/superset/pull/12950?src=pr&el=h1) Report
> Merging [#12950](https://codecov.io/gh/apache/superset/pull/12950?src=pr&el=desc) (597932d) into [master](https://codecov.io/gh/apache/superset/commit/9982fdebd8a312251e3e1821324903efe7e33c06?el=desc) (9982fde) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12950?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12950 +/- ##
=======================================
Coverage 69.14% 69.14%
=======================================
Files 1025 1025
Lines 48767 48767
Branches 5188 5241 +53
=======================================
+ Hits 33718 33720 +2
+ Misses 14915 14913 -2
Partials 134 134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.83% <ø> (ø)` | |
| javascript | `61.84% <ø> (ø)` | |
| python | `67.62% <ø> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12950?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...11ccdd12658\_add\_roles\_relationship\_to\_dashboard.py](https://codecov.io/gh/apache/superset/pull/12950/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lMTFjY2RkMTI2NThfYWRkX3JvbGVzX3JlbGF0aW9uc2hpcF90b19kYXNoYm9hcmQucHk=) | `0.00% <ø> (ø)` | |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/12950/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `92.06% <0.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12950/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `88.31% <0.00%> (+0.43%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12950?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12950?src=pr&el=footer). Last update [9982fde...597932d](https://codecov.io/gh/apache/superset/pull/12950?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io commented on pull request #12950: chore: rename revision to match naming scheme
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #12950:
URL: https://github.com/apache/superset/pull/12950#issuecomment-773526756
# [Codecov](https://codecov.io/gh/apache/superset/pull/12950?src=pr&el=h1) Report
> Merging [#12950](https://codecov.io/gh/apache/superset/pull/12950?src=pr&el=desc) (597932d) into [master](https://codecov.io/gh/apache/superset/commit/9982fdebd8a312251e3e1821324903efe7e33c06?el=desc) (9982fde) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12950?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12950 +/- ##
=======================================
Coverage 69.14% 69.14%
=======================================
Files 1025 1025
Lines 48767 48767
Branches 5188 5241 +53
=======================================
+ Hits 33718 33720 +2
+ Misses 14915 14913 -2
Partials 134 134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.83% <ø> (ø)` | |
| javascript | `61.84% <ø> (ø)` | |
| python | `67.62% <ø> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12950?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...11ccdd12658\_add\_roles\_relationship\_to\_dashboard.py](https://codecov.io/gh/apache/superset/pull/12950/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lMTFjY2RkMTI2NThfYWRkX3JvbGVzX3JlbGF0aW9uc2hpcF90b19kYXNoYm9hcmQucHk=) | `0.00% <ø> (ø)` | |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/12950/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `92.06% <0.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12950/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `88.31% <0.00%> (+0.43%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12950?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12950?src=pr&el=footer). Last update [9982fde...597932d](https://codecov.io/gh/apache/superset/pull/12950?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] etr2460 merged pull request #12950: chore: rename revision to match naming scheme
Posted by GitBox <gi...@apache.org>.
etr2460 merged pull request #12950:
URL: https://github.com/apache/superset/pull/12950
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12950: chore: rename revision to match naming scheme
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12950:
URL: https://github.com/apache/superset/pull/12950#issuecomment-773526756
# [Codecov](https://codecov.io/gh/apache/superset/pull/12950?src=pr&el=h1) Report
> Merging [#12950](https://codecov.io/gh/apache/superset/pull/12950?src=pr&el=desc) (597932d) into [master](https://codecov.io/gh/apache/superset/commit/9982fdebd8a312251e3e1821324903efe7e33c06?el=desc) (9982fde) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12950?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12950 +/- ##
=======================================
Coverage 69.14% 69.14%
=======================================
Files 1025 1025
Lines 48767 48767
Branches 5188 5241 +53
=======================================
+ Hits 33718 33720 +2
+ Misses 14915 14913 -2
Partials 134 134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.83% <ø> (ø)` | |
| javascript | `61.84% <ø> (ø)` | |
| python | `67.62% <ø> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12950?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...11ccdd12658\_add\_roles\_relationship\_to\_dashboard.py](https://codecov.io/gh/apache/superset/pull/12950/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lMTFjY2RkMTI2NThfYWRkX3JvbGVzX3JlbGF0aW9uc2hpcF90b19kYXNoYm9hcmQucHk=) | `0.00% <ø> (ø)` | |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/12950/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `92.06% <0.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12950/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `88.31% <0.00%> (+0.43%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12950?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12950?src=pr&el=footer). Last update [9982fde...597932d](https://codecov.io/gh/apache/superset/pull/12950?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov-io edited a comment on pull request #12950: chore: rename revision to match naming scheme
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #12950:
URL: https://github.com/apache/superset/pull/12950#issuecomment-773526756
# [Codecov](https://codecov.io/gh/apache/superset/pull/12950?src=pr&el=h1) Report
> Merging [#12950](https://codecov.io/gh/apache/superset/pull/12950?src=pr&el=desc) (597932d) into [master](https://codecov.io/gh/apache/superset/commit/9982fdebd8a312251e3e1821324903efe7e33c06?el=desc) (9982fde) will **increase** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/12950?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12950 +/- ##
=======================================
Coverage 69.14% 69.14%
=======================================
Files 1025 1025
Lines 48767 48767
Branches 5188 5241 +53
=======================================
+ Hits 33718 33720 +2
+ Misses 14915 14913 -2
Partials 134 134
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `50.83% <ø> (ø)` | |
| javascript | `61.84% <ø> (ø)` | |
| python | `67.62% <ø> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/12950?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...11ccdd12658\_add\_roles\_relationship\_to\_dashboard.py](https://codecov.io/gh/apache/superset/pull/12950/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbWlncmF0aW9ucy92ZXJzaW9ucy9lMTFjY2RkMTI2NThfYWRkX3JvbGVzX3JlbGF0aW9uc2hpcF90b19kYXNoYm9hcmQucHk=) | `0.00% <ø> (ø)` | |
| [...set-frontend/src/dashboard/util/getDropPosition.js](https://codecov.io/gh/apache/superset/pull/12950/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldERyb3BQb3NpdGlvbi5qcw==) | `92.06% <0.00%> (ø)` | |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/12950/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `88.31% <0.00%> (+0.43%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/12950?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/12950?src=pr&el=footer). Last update [9982fde...597932d](https://codecov.io/gh/apache/superset/pull/12950?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] etr2460 merged pull request #12950: chore: rename revision to match naming scheme
Posted by GitBox <gi...@apache.org>.
etr2460 merged pull request #12950:
URL: https://github.com/apache/superset/pull/12950
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org