[GitHub] [incubator-daffodil] stevedlawrence commented on issue #269: DAFFODIL-2200. xs:import problems with xsd files provided in daffodil-lib

[GitBox <gi...@apache.org>]

stevedlawrence commented on issue #269: DAFFODIL-2200. xs:import problems with xsd files provided in daffodil-lib
URL: https://github.com/apache/incubator-daffodil/pull/269#issuecomment-535533801
 
 
   It looks like the GitHub actions CI is failing due to https://github.com/actions/checkout/issues/23. I think we'll just have to rely on TravisCI until this issue is resolved.
   
   Though, it looks like the first part of the bug is still an issue. The ``dfdlx.xsd`` file has the following lines:
   ```xml
     <xs:import namespace="urn:ogf:dfdl:2013:imp:daffodil.apache.org:2018:int" schemaLocation="xsd/dafint.xsd" />
     <xs:import namespace="http://www.ogf.org/dfdl/dfdl-1.0/" schemaLocation="xsd/DFDL_part3_model.xsd" />
   ```
   The bug report says that the schemaLocation attributes should be this:
   ```xml
     <xs:import namespace="urn:ogf:dfdl:2013:imp:daffodil.apache.org:2018:int" schemaLocation="dafint.xsd" />
     <xs:import namespace="http://www.ogf.org/dfdl/dfdl-1.0/" schemaLocation="DFDL_part3_model.xsd" />
   ```
   I.e., the "xsd" directory is removed from the schemaLocation. I'd doesn't look like that was fixed as another PR. I *think* the bug is right and the xsd should be removed.
   
   Also, I recommend changing the commit message to remove the squashed commit messge "fixed broken tag" since the squashed commit doesn't actually fix any broken tags. Also, in the Daffodil project, the standard is to list the bug number at the end of the commit message, so your commit message should look something like this:
   
   > xs:import problems with xsd files provided in daffodil-lib
   >
   > Removed extra whitespace
   >
   > DAFFODIL-2200

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services