[GitHub] [maven-shared-utils] michael-o commented on a diff in pull request #113: [MSHARED-1072] fix blocking in StreamFeeder

[GitBox <gi...@apache.org>]

michael-o commented on code in PR #113:
URL: https://github.com/apache/maven-shared-utils/pull/113#discussion_r931476426


##########
src/main/java/org/apache/maven/shared/utils/cli/CommandLineUtils.java:
##########
@@ -288,31 +279,13 @@ public Integer call()
                     errorPumper.setName( "StreamPumper-systemErr" );
                     errorPumper.start();
 
-                    int returnValue;
-                    if ( timeoutInSeconds <= 0 )
+                    if ( timeoutInSeconds > 0 && !p.waitFor( timeoutInSeconds, TimeUnit.SECONDS ) )

Review Comment:
   Where is the kill for this process? It may continue to run as a zombie forever.



##########
src/main/java/org/apache/maven/shared/utils/cli/CommandLineTimeOutException.java:
##########
@@ -41,4 +40,11 @@ public CommandLineTimeOutException( String message, Throwable cause )
         super( message, cause );
     }
 
+    /**
+     * @param message The message of the exception.
+     */
+    public CommandLineTimeOutException( String message )

Review Comment:
   `Timeout` according to https://www.oxfordlearnersdictionaries.com/definition/english/timeout?q=timeout



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org