[GitHub] [flink-kubernetes-operator] bgeng777 commented on a change in pull request #107: [hotfix][FLINK-26832] Some minor logging / observe fixes

[GitBox <gi...@apache.org>]

bgeng777 commented on a change in pull request #107:
URL: https://github.com/apache/flink-kubernetes-operator/pull/107#discussion_r834350619



##########
File path: flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/observer/BaseObserver.java
##########
@@ -103,10 +111,12 @@ protected void observeJmDeployment(
                 return;
             }
 
+            logger.info("JobManager is deployed but not ready yet", status);

Review comment:
       The old code seems more clear:
   ```
   logger.info("JobManager deployment exists but not ready, status {}", status);
   ```
   The new description `deployed but not ready yet` is not wrong but is too close to the enum `DEPLOYED_NOT_READY`, while we actully set the status to `DEPLOYING`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org