[GitHub] [daffodil] stevedlawrence opened a new pull request, #1083: Ensure UTF-8 is used during CLI tests

["stevedlawrence (via GitHub)" <gi...@apache.org>]

stevedlawrence opened a new pull request, #1083:
URL: https://github.com/apache/daffodil/pull/1083

   Daffodil should ignore the Java file.encoding property, only using the encoding specified in a DFDL schema. This goes for all of our tests as well. The one place where this isn't the case is with CLI tests, which can lead to some tests failing or hanging if run on a system with a different encoding.
   
   To fix this, this modifies the CLI test infrastructure to run CLI tests with a UTF-8 encoding, regardless of the file.encoding property provided to Java, since parts of the CLI, specifically the debugger, use special UTF-8 characters and have tests that expect them.
   
   This also modifies the Windows/Java 8 GitHub action to set the Java file.encoding property to US-ASCII. This ensures that if we ever do add file.encoding specific behavior to Daffodil then hopefully a test will fail. Note that newer versions of SBT do not get the file.encoding property from LANG so this also modifies the GitHub actions so that we can specify the encoding and LANG separately.
   
   This also found tests for stringAsXml that relied on file.encoding instead of specifying an encoding. Fortunately, this was just broken tests and not a broken stringAsXml implementation.
   
   DAFFODIL-2612


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [daffodil] stevedlawrence merged pull request #1083: Ensure UTF-8 is used during CLI tests

["stevedlawrence (via GitHub)" <gi...@apache.org>]

stevedlawrence merged PR #1083:
URL: https://github.com/apache/daffodil/pull/1083


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@daffodil.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org