You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by er...@apache.org on 2019/09/27 22:11:08 UTC
[commons-geometry] branch master updated: Slightly better
assertions (unit tests).
This is an automated email from the ASF dual-hosted git repository.
erans pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-geometry.git
The following commit(s) were added to refs/heads/master by this push:
new 154ae1c Slightly better assertions (unit tests).
154ae1c is described below
commit 154ae1c5073b249e1843008fdbed26f907facf7c
Author: Gilles Sadowski <gi...@harfang.homelinux.org>
AuthorDate: Sat Sep 28 00:10:18 2019 +0200
Slightly better assertions (unit tests).
---
.../java/org/apache/commons/geometry/euclidean/oned/Vector1DTest.java | 2 +-
.../java/org/apache/commons/geometry/euclidean/threed/Vector3DTest.java | 2 +-
.../java/org/apache/commons/geometry/euclidean/twod/Vector2DTest.java | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/oned/Vector1DTest.java b/commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/oned/Vector1DTest.java
index e1fc1f6..3cd2534 100644
--- a/commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/oned/Vector1DTest.java
+++ b/commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/oned/Vector1DTest.java
@@ -688,7 +688,7 @@ public class Vector1DTest {
public void testUnitFactoryOptimization() {
// An already normalized vector will avoid unnecessary creation.
final Vector1D v = Vector1D.of(3).normalize();
- Assert.assertTrue(v.normalize() == v);
+ Assert.assertSame(v, v.normalize());
}
private void checkVector(Vector1D v, double x) {
diff --git a/commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/threed/Vector3DTest.java b/commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/threed/Vector3DTest.java
index 03f90c0..f46b85a 100644
--- a/commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/threed/Vector3DTest.java
+++ b/commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/threed/Vector3DTest.java
@@ -1211,7 +1211,7 @@ public class Vector3DTest {
public void testUnitFactoryOptimization() {
// An already normalized vector will avoid unnecessary creation.
final Vector3D v = Vector3D.of(3, 4, 5).normalize();
- Assert.assertTrue(v.normalize() == v);
+ Assert.assertSame(v, v.normalize());
}
private void checkVector(Vector3D v, double x, double y, double z) {
diff --git a/commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/twod/Vector2DTest.java b/commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/twod/Vector2DTest.java
index d693a5a..3f92960 100644
--- a/commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/twod/Vector2DTest.java
+++ b/commons-geometry-euclidean/src/test/java/org/apache/commons/geometry/euclidean/twod/Vector2DTest.java
@@ -1027,7 +1027,7 @@ public class Vector2DTest {
public void testUnitFactoryOptimization() {
// An already normalized vector will avoid unnecessary creation.
final Vector2D v = Vector2D.of(4, 5).normalize();
- Assert.assertTrue(v.normalize() == v);
+ Assert.assertSame(v, v.normalize());
}
private void checkVector(Vector2D v, double x, double y) {