You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/03/16 23:35:20 UTC
[GitHub] [airflow] kaxil opened a new pull request #7742: [AIRFLOW-5705] Fix
bug in Secrets Backend
kaxil opened a new pull request #7742: [AIRFLOW-5705] Fix bug in Secrets Backend
URL: https://github.com/apache/airflow/pull/7742
Follow up of https://github.com/apache/airflow/pull/6376 . There were some bugs where the renaming of configs was not applied at all places
---
Issue link: WILL BE INSERTED BY [boring-cyborg](https://github.com/kaxil/boring-cyborg)
Make sure to mark the boxes below before creating PR: [x]
- [x] Description above provides context of the change
- [x] Commit message/PR title starts with `[AIRFLOW-NNNN]`. AIRFLOW-NNNN = JIRA ID<sup>*</sup>
- [ ] Unit tests coverage for changes (not needed for documentation changes)
- [x] Commits follow "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)"
- [x] Relevant documentation is updated including usage instructions.
- [x] I will engage committers as explained in [Contribution Workflow Example](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#contribution-workflow-example).
<sup>*</sup> For document-only changes commit message can start with `[AIRFLOW-XXXX]`.
---
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
Read the [Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines) for more information.
cc @dstandish
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] dstandish commented on issue #7742: [AIRFLOW-5705] Fix
bug in Secrets Backend
Posted by GitBox <gi...@apache.org>.
dstandish commented on issue #7742: [AIRFLOW-5705] Fix bug in Secrets Backend
URL: https://github.com/apache/airflow/pull/7742#issuecomment-599835607
Sorry @kaxil / thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io edited a comment on issue #7742:
[AIRFLOW-5705] Fix bug in Secrets Backend
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on issue #7742: [AIRFLOW-5705] Fix bug in Secrets Backend
URL: https://github.com/apache/airflow/pull/7742#issuecomment-599829086
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7742?src=pr&el=h1) Report
> Merging [#7742](https://codecov.io/gh/apache/airflow/pull/7742?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a8b5fc74d07e50c91bb64cb66ca1a450aa5ce6e1&el=desc) will **decrease** coverage by `0.76%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/airflow/pull/7742?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7742 +/- ##
==========================================
- Coverage 86.94% 86.18% -0.77%
==========================================
Files 915 915
Lines 44176 44176
==========================================
- Hits 38407 38071 -336
- Misses 5769 6105 +336
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7742?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/secrets/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/7742/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZWNyZXRzL19faW5pdF9fLnB5) | `100.00% <100.00%> (+10.25%)` | :arrow_up: |
| [...flow/providers/apache/cassandra/hooks/cassandra.py](https://codecov.io/gh/apache/airflow/pull/7742/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2Nhc3NhbmRyYS9ob29rcy9jYXNzYW5kcmEucHk=) | `21.51% <0.00%> (-72.16%)` | :arrow_down: |
| [...w/providers/apache/hive/operators/mysql\_to\_hive.py](https://codecov.io/gh/apache/airflow/pull/7742/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvYXBhY2hlL2hpdmUvb3BlcmF0b3JzL215c3FsX3RvX2hpdmUucHk=) | `35.84% <0.00%> (-64.16%)` | :arrow_down: |
| [airflow/kubernetes/volume\_mount.py](https://codecov.io/gh/apache/airflow/pull/7742/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZV9tb3VudC5weQ==) | `44.44% <0.00%> (-55.56%)` | :arrow_down: |
| [airflow/providers/postgres/operators/postgres.py](https://codecov.io/gh/apache/airflow/pull/7742/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcG9zdGdyZXMvb3BlcmF0b3JzL3Bvc3RncmVzLnB5) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [airflow/providers/redis/operators/redis\_publish.py](https://codecov.io/gh/apache/airflow/pull/7742/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvcmVkaXMvb3BlcmF0b3JzL3JlZGlzX3B1Ymxpc2gucHk=) | `50.00% <0.00%> (-50.00%)` | :arrow_down: |
| [airflow/kubernetes/volume.py](https://codecov.io/gh/apache/airflow/pull/7742/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3ZvbHVtZS5weQ==) | `52.94% <0.00%> (-47.06%)` | :arrow_down: |
| [airflow/providers/mongo/sensors/mongo.py](https://codecov.io/gh/apache/airflow/pull/7742/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbW9uZ28vc2Vuc29ycy9tb25nby5weQ==) | `53.33% <0.00%> (-46.67%)` | :arrow_down: |
| [airflow/kubernetes/pod\_launcher.py](https://codecov.io/gh/apache/airflow/pull/7742/diff?src=pr&el=tree#diff-YWlyZmxvdy9rdWJlcm5ldGVzL3BvZF9sYXVuY2hlci5weQ==) | `47.18% <0.00%> (-45.08%)` | :arrow_down: |
| [airflow/providers/mysql/operators/mysql.py](https://codecov.io/gh/apache/airflow/pull/7742/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvbXlzcWwvb3BlcmF0b3JzL215c3FsLnB5) | `55.00% <0.00%> (-45.00%)` | :arrow_down: |
| ... and [11 more](https://codecov.io/gh/apache/airflow/pull/7742/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7742?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7742?src=pr&el=footer). Last update [a8b5fc7...dc1c48e](https://codecov.io/gh/apache/airflow/pull/7742?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] codecov-io commented on issue #7742: [AIRFLOW-5705] Fix
bug in Secrets Backend
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #7742: [AIRFLOW-5705] Fix bug in Secrets Backend
URL: https://github.com/apache/airflow/pull/7742#issuecomment-599829086
# [Codecov](https://codecov.io/gh/apache/airflow/pull/7742?src=pr&el=h1) Report
> Merging [#7742](https://codecov.io/gh/apache/airflow/pull/7742?src=pr&el=desc) into [master](https://codecov.io/gh/apache/airflow/commit/a8b5fc74d07e50c91bb64cb66ca1a450aa5ce6e1?src=pr&el=desc) will **decrease** coverage by `22.41%`.
> The diff coverage is `100%`.
[](https://codecov.io/gh/apache/airflow/pull/7742?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #7742 +/- ##
===========================================
- Coverage 86.94% 64.52% -22.42%
===========================================
Files 915 914 -1
Lines 44176 44163 -13
===========================================
- Hits 38407 28498 -9909
- Misses 5769 15665 +9896
```
| [Impacted Files](https://codecov.io/gh/apache/airflow/pull/7742?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [airflow/secrets/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/7742/diff?src=pr&el=tree#diff-YWlyZmxvdy9zZWNyZXRzL19faW5pdF9fLnB5) | `94.87% <100%> (+5.12%)` | :arrow_up: |
| [...low/contrib/operators/wasb\_delete\_blob\_operator.py](https://codecov.io/gh/apache/airflow/pull/7742/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy93YXNiX2RlbGV0ZV9ibG9iX29wZXJhdG9yLnB5) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/contrib/hooks/vertica\_hook.py](https://codecov.io/gh/apache/airflow/pull/7742/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL2hvb2tzL3ZlcnRpY2FfaG9vay5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/contrib/sensors/\_\_init\_\_.py](https://codecov.io/gh/apache/airflow/pull/7742/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvX19pbml0X18ucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/hooks/mssql\_hook.py](https://codecov.io/gh/apache/airflow/pull/7742/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy9tc3NxbF9ob29rLnB5) | `0% <0%> (-100%)` | :arrow_down: |
| [...viders/docker/example\_dags/example\_docker\_swarm.py](https://codecov.io/gh/apache/airflow/pull/7742/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZG9ja2VyL2V4YW1wbGVfZGFncy9leGFtcGxlX2RvY2tlcl9zd2FybS5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/hooks/webhdfs\_hook.py](https://codecov.io/gh/apache/airflow/pull/7742/diff?src=pr&el=tree#diff-YWlyZmxvdy9ob29rcy93ZWJoZGZzX2hvb2sucHk=) | `0% <0%> (-100%)` | :arrow_down: |
| [airflow/contrib/sensors/emr\_base\_sensor.py](https://codecov.io/gh/apache/airflow/pull/7742/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL3NlbnNvcnMvZW1yX2Jhc2Vfc2Vuc29yLnB5) | `0% <0%> (-100%)` | :arrow_down: |
| [...irflow/contrib/operators/slack\_webhook\_operator.py](https://codecov.io/gh/apache/airflow/pull/7742/diff?src=pr&el=tree#diff-YWlyZmxvdy9jb250cmliL29wZXJhdG9ycy9zbGFja193ZWJob29rX29wZXJhdG9yLnB5) | `0% <0%> (-100%)` | :arrow_down: |
| [...providers/google/cloud/example\_dags/example\_dlp.py](https://codecov.io/gh/apache/airflow/pull/7742/diff?src=pr&el=tree#diff-YWlyZmxvdy9wcm92aWRlcnMvZ29vZ2xlL2Nsb3VkL2V4YW1wbGVfZGFncy9leGFtcGxlX2RscC5weQ==) | `0% <0%> (-100%)` | :arrow_down: |
| ... and [491 more](https://codecov.io/gh/apache/airflow/pull/7742/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/airflow/pull/7742?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/airflow/pull/7742?src=pr&el=footer). Last update [a8b5fc7...dc1c48e](https://codecov.io/gh/apache/airflow/pull/7742?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil merged pull request #7742: [AIRFLOW-5705] Fix bug
in Secrets Backend
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #7742: [AIRFLOW-5705] Fix bug in Secrets Backend
URL: https://github.com/apache/airflow/pull/7742
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil commented on issue #7742: [AIRFLOW-5705] Fix bug in
Secrets Backend
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #7742: [AIRFLOW-5705] Fix bug in Secrets Backend
URL: https://github.com/apache/airflow/pull/7742#issuecomment-599804892
I will add more tests as earlier tests didn't cover this
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [airflow] kaxil edited a comment on issue #7742: [AIRFLOW-5705] Fix
bug in Secrets Backend
Posted by GitBox <gi...@apache.org>.
kaxil edited a comment on issue #7742: [AIRFLOW-5705] Fix bug in Secrets Backend
URL: https://github.com/apache/airflow/pull/7742#issuecomment-599804892
~I will add more tests as earlier tests didn't cover this~ **Added**
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services