You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by da...@apache.org on 2018/01/23 09:41:17 UTC
[camel] 02/04: Added A record and unit tests
This is an automated email from the ASF dual-hosted git repository.
davsclaus pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/camel.git
commit 3f9c1ef64be44573478d2f052afee8fd3bdf4ada
Author: Max Fortun <Ma...@wsj.com>
AuthorDate: Fri Jan 19 12:37:41 2018 -0500
Added A record and unit tests
---
.../camel/component/dns/policy/DnsActivation.java | 7 ++-----
.../component/dns/policy/DnsActivationTest.java | 22 ++++++++++++++++++++++
2 files changed, 24 insertions(+), 5 deletions(-)
diff --git a/components/camel-dns/src/main/java/org/apache/camel/component/dns/policy/DnsActivation.java b/components/camel-dns/src/main/java/org/apache/camel/component/dns/policy/DnsActivation.java
index ddf352e..4eb8ad5 100644
--- a/components/camel-dns/src/main/java/org/apache/camel/component/dns/policy/DnsActivation.java
+++ b/components/camel-dns/src/main/java/org/apache/camel/component/dns/policy/DnsActivation.java
@@ -24,7 +24,7 @@ import org.slf4j.LoggerFactory;
public class DnsActivation {
private static final transient Logger logger = LoggerFactory.getLogger(DnsActivation.class);
- private final static String[] DNS_TYPES_CNAME = {"CNAME"};
+ private final static String[] DNS_TYPES = {"CNAME", "A"};
private String hostname;
private List<String> resolvesTo = new ArrayList<String>();
@@ -70,7 +70,7 @@ public class DnsActivation {
String hostname = hostnames.remove(0);
InetAddress inetAddress = InetAddress.getByName(hostname);
InitialDirContext initialDirContext = new InitialDirContext();
- Attributes attributes = initialDirContext.getAttributes("dns:/" + inetAddress.getHostName(), DNS_TYPES_CNAME);
+ Attributes attributes = initialDirContext.getAttributes("dns:/" + inetAddress.getHostName(), DNS_TYPES);
attributeEnumeration = attributes.getAll();
while(attributeEnumeration.hasMore()) {
Attribute attribute = (Attribute)attributeEnumeration.next();
@@ -113,9 +113,6 @@ public class DnsActivation {
while (inetAddressesEnumeration.hasMoreElements()) {
InetAddress inetAddress = inetAddressesEnumeration.nextElement();
String ip = inetAddress.getHostAddress();
- if(ip.startsWith("127.")) {
- continue;
- }
logger.debug("Local ip: "+ip);
localIps.add(ip);
}
diff --git a/components/camel-dns/src/test/java/org/apache/camel/component/dns/policy/DnsActivationTest.java b/components/camel-dns/src/test/java/org/apache/camel/component/dns/policy/DnsActivationTest.java
new file mode 100644
index 0000000..ad74e09
--- /dev/null
+++ b/components/camel-dns/src/test/java/org/apache/camel/component/dns/policy/DnsActivationTest.java
@@ -0,0 +1,22 @@
+package org.apache.camel.component.dns.policy;
+
+import java.util.Arrays;
+import java.util.List;
+
+import org.junit.Test;
+
+import static org.junit.Assert.assertTrue;
+import static org.junit.Assert.assertFalse;
+
+public class DnsActivationTest {
+ @Test
+ public void testDnsActivation() throws Exception {
+
+ DnsActivation dnsActivationActive = new DnsActivation("localhost", Arrays.asList("127.0.0.1"));
+ assertTrue(dnsActivationActive.isActive());
+
+ DnsActivation dnsActivationInactive = new DnsActivation("localhost", Arrays.asList("127.0.0.2"));
+ assertFalse(dnsActivationInactive.isActive());
+
+ }
+}
--
To stop receiving notification emails like this one, please contact
davsclaus@apache.org.