You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@submarine.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/05/31 13:00:00 UTC
[jira] [Updated] (SUBMARINE-841) Modify hard-coded URLs in frontend
E2E test to soft-coded URLs
[ https://issues.apache.org/jira/browse/SUBMARINE-841?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
ASF GitHub Bot updated SUBMARINE-841:
-------------------------------------
Labels: pull-request-available (was: )
> Modify hard-coded URLs in frontend E2E test to soft-coded URLs
> --------------------------------------------------------------
>
> Key: SUBMARINE-841
> URL: https://issues.apache.org/jira/browse/SUBMARINE-841
> Project: Apache Submarine
> Issue Type: Improvement
> Components: Cloud-native Deployment, E2E Test
> Reporter: Kai-Hsun Chen
> Assignee: Kai-Hsun Chen
> Priority: Major
> Labels: pull-request-available
> Fix For: 0.6.0
>
>
> Currently, some frontend E2E tests determine whether a test passes or fails based on a hard-coded URL and port.
>
> Take [dataIT|https://github.com/apache/submarine/blob/master/submarine-test/test-e2e/src/test/java/org/apache/submarine/integration/dataIT.java#L60] as an example, the following code hard-coded the expected URL to "http://localhost:8080/workbench/data". However, we cannot ensure that Submarine Workbench will always run on "http://localhost:8080". Hence, this issue aims to change the hard-coded URL to a soft-coded URL.
>
> {code:java}
> Assert.assertEquals(driver.getCurrentUrl(),"http://localhost:8080/workbench/data");{code}
>
>
> Hardcoding vs Softcoding: [https://simplicable.com/new/hardcoding-vs-softcoding]
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org