You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/02/10 12:59:32 UTC

[GitHub] [airflow] dennis-weyland-by opened a new issue #21493: Option to make UI centered around execution date rather than the start_date of interval

dennis-weyland-by opened a new issue #21493:
URL: https://github.com/apache/airflow/issues/21493


   ### Description
   
   Consider the following example:
   The current datetime is 2022-02-10 09:45 CET and airflow executed two runs:
   
   - daily_run scheduled to run every day at 09:43 CET
   - maintenance triggered manually at 2022-02-10 09:41 CET
   
   In the UI it looks like this:
   ![Screenshot 2022-02-10 at 09 45 55](https://user-images.githubusercontent.com/71711396/153408199-14571a1d-c59e-4af8-858a-7a98ff7fe147.png)
   
   From someone new to airflow there are some unintuitive things for display:
   
   - Although both dags ran on the same day, they display different dates in the last run
   - The DateTime in the Next run column for daily_run is in the past
   
   On a technical level, this is documented. Airflow runs its schedule after the schedule interval is completed and what is displayed is the start_date of the interval similar to the start_date parameter of a DAG. As a developer, which works with Airflow, I have to read the documentation and act accordingly. So far this is fine.
   
   My point is, that not every consumer of the UI is familiar with Airflow and to some, this is very confusing and counterintuitive. 
   As a developer, I would like to have the option to switch the displayed days to the execution/run after date. This information is also already  there when using the info tooltip:
   ![Screenshot 2022-02-10 at 11 09 31](https://user-images.githubusercontent.com/71711396/153410060-d35f63de-d877-4ab2-920f-c8f45c8bbc21.png) ![Screenshot 2022-02-10 at 11 09 44](https://user-images.githubusercontent.com/71711396/153410093-7bfad215-54bc-40e4-acac-27fde3983190.png)
   
   **Summary**
   Introduce a config flag for the web-server that on the front page the actual time of the future/past execution of a scheduled dag is shown. Since this is a behavior inconsistent with internal airflow behavior, the flag should be disabled by default.
   
   **Optional: Extending this to DAg Details page**
   The Frontpage is not the only place the behavior is shown. So it might make sense that the flag would also change the following examples:
   **Tree View:**
   
   - Upper right: next Run
   - Calendar Filter
   - Column Name (and ordering) in Tree View
   
   ![Screenshot 2022-02-10 at 11 07 29](https://user-images.githubusercontent.com/71711396/153411045-e7c423b3-cb8d-449e-b81e-f70b629acb55.png)
   
   **Calendar**:
   
   ![Screenshot 2022-02-10 at 11 08 36](https://user-images.githubusercontent.com/71711396/153411446-ef5c48c3-3f52-4e51-915d-cccea90500ce.png)
   
    **Are you willing to submit a PR?** 
   My lack of javascript logic prevents me from doing a pr myself, but I would be willing to help on this issue if needed.
   
   ### Use case/motivation
   
   I use airflow to schedule/orchestrate ML pipelines like model training, predicting, and so on. I want to use the Airflow UI to further enable those pipelines to an audience, which is not accustomed to airflow. It turned out that the current behavior of how dates are displayed (especially with a mix of scheduled and manually triggered tasks) is very confusing for this use case and makes it hard to onboard people as WebUI-only users.
   
   ### Related issues
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] dennis-weyland-by commented on issue #21493: Option to make UI centered around execution date rather than the start_date of interval

Posted by GitBox <gi...@apache.org>.
dennis-weyland-by commented on issue #21493:
URL: https://github.com/apache/airflow/issues/21493#issuecomment-1047536108


   Yes, thank you. I wasn't aware that the execution date is aligned with the start of the interval and not the end. But yes I agree, that the UI should display the end of the interval then. Do you think that this should be default behavior or would you rather prefer a feature flag and stay with the current behavior as default?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] dennis-weyland-by commented on issue #21493: Option to make UI centered around execution date rather than the start_date of interval

Posted by GitBox <gi...@apache.org>.
dennis-weyland-by commented on issue #21493:
URL: https://github.com/apache/airflow/issues/21493#issuecomment-1046982460


   @uranusjr @bbovenzi any updates?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] bbovenzi commented on issue #21493: Option to make UI centered around execution date rather than the start_date of interval

Posted by GitBox <gi...@apache.org>.
bbovenzi commented on issue #21493:
URL: https://github.com/apache/airflow/issues/21493#issuecomment-1053625101


   Yes, the data interval end date lines up better. It shouldn't be hard to update all the next run areas of the UI to use that instead.
   Also, I think we show too many dates in our tooltips which also causes confusion. I'm playing around with a better details view, to place all of these other dates so that we can simplify our at-a-glance tooltips.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] bbovenzi commented on issue #21493: Option to make UI centered around execution date rather than the start_date of interval

Posted by GitBox <gi...@apache.org>.
bbovenzi commented on issue #21493:
URL: https://github.com/apache/airflow/issues/21493#issuecomment-1036519651


   @uranusjr I'd be curious to hear your thoughts after all of the recent `schedule_interval` changes. I'm happy to update the UI to work with whatever is most useful for users.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] uranusjr commented on issue #21493: Option to make UI centered around execution date rather than the start_date of interval

Posted by GitBox <gi...@apache.org>.
uranusjr commented on issue #21493:
URL: https://github.com/apache/airflow/issues/21493#issuecomment-1047489537


   If I understand what you’re trying to say correctly, the situaion is actually entirely the other way around. _It evolves around execution date_. All the UI confusions you have (runs at the same date displayed as different dates) happen because those dates are _execution dates_, not _data intervals_. Yes, a manual run’s execution date points to its data interval’s end. So to solve your problem, the UI needs to be modified to evolve around the data interval instead (and I think it actually may make more sense to make it evolve around the _end_ of the data interval than the start), not the execution date.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] boring-cyborg[bot] commented on issue #21493: Option to make UI centered around execution date rather than the start_date of interval

Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on issue #21493:
URL: https://github.com/apache/airflow/issues/21493#issuecomment-1034892895


   Thanks for opening your first issue here! Be sure to follow the issue template!
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [airflow] uranusjr commented on issue #21493: Option to make UI centered around execution date rather than the start_date of interval

Posted by GitBox <gi...@apache.org>.
uranusjr commented on issue #21493:
URL: https://github.com/apache/airflow/issues/21493#issuecomment-1047568369


   Not sure (honestly I kind of semi-delibrately avoided this when we first added data intervals to the hover dialog box); personally I’d want to just flip everything over, but @bbovenzi probably has a better idea how backward compatibility needs to be dealt with in the web UI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org