You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/04/27 12:04:30 UTC

[GitHub] [nifi-minifi-cpp] szaszm opened a new pull request, #1319: MINIFICPP-1816 adapt bootstrap to Ubuntu 20.04

szaszm opened a new pull request, #1319:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1319

   Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
   
   In order to streamline the review of the contribution we ask you
   to ensure the following steps have been taken:
   
   ### For all changes:
   - [x] Is there a JIRA ticket associated with this PR? Is it referenced
        in the commit message?
   
   - [x] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
   
   - [x] Has your PR been rebased against the latest commit within the target branch (typically main)?
   
   - [x] Is your initial contribution a single, squashed commit?
   
   ### For code changes:
   - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
   - [x] If applicable, have you updated the LICENSE file?
   - [x] If applicable, have you updated the NOTICE file?
   
   ### For documentation related changes:
   - [x] Have you ensured that format looks appropriate for the output in which it is rendered?
   
   ### Note:
   Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1319: MINIFICPP-1816 adapt bootstrap to Ubuntu 22.04

Posted by GitBox <gi...@apache.org>.
fgerlits commented on code in PR #1319:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1319#discussion_r859781765


##########
aptitude.sh:
##########
@@ -23,7 +23,7 @@ verify_enable_platform(){
 add_os_flags() {
     CC=gcc
     CXX=g++
-    if [[ "$OS" = Ubuntu* ]]; then
+    if [[ "$OS" = Ubuntu* ]] && [ "$OS_MAJOR" -lt 22 ]; then

Review Comment:
   It's a bit weird to mix `[[ ]]` and `[ ]`.  Why not 
   ```suggestion
       if [[ "$OS" = Ubuntu* && "$OS_MAJOR" -lt 22 ]]; then
   ```
   ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1319: MINIFICPP-1816 adapt bootstrap to Ubuntu 22.04

Posted by GitBox <gi...@apache.org>.
adamdebreceni commented on code in PR #1319:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1319#discussion_r863559349


##########
aptitude.sh:
##########
@@ -44,7 +44,7 @@ bootstrap_cmake(){
 build_deps(){
     ## need to account for debian
     compiler_pkgs="gcc g++"
-    if [[ "$OS" = Ubuntu* ]]; then
+    if [[ "$OS" = Ubuntu* && "$OS_MAJOR" -lt 22 ]]; then

Review Comment:
   are these required changes for a successful build on 22.04? if so, an accompanying ci job could ensure that the build stays successful



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a diff in pull request #1319: MINIFICPP-1816 adapt bootstrap to Ubuntu 22.04

Posted by GitBox <gi...@apache.org>.
adamdebreceni commented on code in PR #1319:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1319#discussion_r863559349


##########
aptitude.sh:
##########
@@ -44,7 +44,7 @@ bootstrap_cmake(){
 build_deps(){
     ## need to account for debian
     compiler_pkgs="gcc g++"
-    if [[ "$OS" = Ubuntu* ]]; then
+    if [[ "$OS" = Ubuntu* && "$OS_MAJOR" -lt 22 ]]; then

Review Comment:
   are these changes required for a successful build on 22.04? if so, an accompanying ci job could ensure that the build stays successful



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1319: MINIFICPP-1816 adapt bootstrap to Ubuntu 22.04

Posted by GitBox <gi...@apache.org>.
szaszm commented on code in PR #1319:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1319#discussion_r859806067


##########
aptitude.sh:
##########
@@ -23,7 +23,7 @@ verify_enable_platform(){
 add_os_flags() {
     CC=gcc
     CXX=g++
-    if [[ "$OS" = Ubuntu* ]]; then
+    if [[ "$OS" = Ubuntu* ]] && [ "$OS_MAJOR" -lt 22 ]; then

Review Comment:
   I generally prefer the portable `test`/`[`, but it doesn't support pattern matching. I can change it to use only `[[`, hopefully it will work.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] martinzink closed pull request #1319: MINIFICPP-1816 adapt bootstrap to Ubuntu 22.04

Posted by GitBox <gi...@apache.org>.
martinzink closed pull request #1319: MINIFICPP-1816 adapt bootstrap to Ubuntu 22.04
URL: https://github.com/apache/nifi-minifi-cpp/pull/1319


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1319: MINIFICPP-1816 adapt bootstrap to Ubuntu 22.04

Posted by GitBox <gi...@apache.org>.
szaszm commented on code in PR #1319:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1319#discussion_r863610804


##########
aptitude.sh:
##########
@@ -44,7 +44,7 @@ bootstrap_cmake(){
 build_deps(){
     ## need to account for debian
     compiler_pkgs="gcc g++"
-    if [[ "$OS" = Ubuntu* ]]; then
+    if [[ "$OS" = Ubuntu* && "$OS_MAJOR" -lt 22 ]]; then

Review Comment:
   They are not required for a successful build. We just no longer install dependencies from 3rd party repos that are recent enough in the official ones.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1319: MINIFICPP-1816 adapt bootstrap to Ubuntu 22.04

Posted by GitBox <gi...@apache.org>.
szaszm commented on code in PR #1319:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1319#discussion_r860796775


##########
aptitude.sh:
##########
@@ -23,7 +23,7 @@ verify_enable_platform(){
 add_os_flags() {
     CC=gcc
     CXX=g++
-    if [[ "$OS" = Ubuntu* ]]; then
+    if [[ "$OS" = Ubuntu* ]] && [ "$OS_MAJOR" -lt 22 ]; then

Review Comment:
   [f7a16d7](https://github.com/apache/nifi-minifi-cpp/pull/1319/commits/f7a16d798dd8cc9960d89f61f10d89b5f9e8550a)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org