[jira] Commented: (CXF-1623) Wrong method implementation in AnnotationHandlerChainBuilder

["Richard Opalka (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CXF-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12601631#action_12601631 ] 

Richard Opalka commented on CXF-1623:
-------------------------------------

The following method is either wrongly implemented or it has wrong preconditions:

private boolean protocolMatches(Element el, String id) {
        if (id == null) {
            return true;
        }
        String name = el.getTextContent().trim();
        if ("##SOAP11_HTTP".equals(name)) {
            name = "http://schemas.xmlsoap.org/wsdl/soap/http";
        } else if ("##SOAP11_HTTP_MTOM".equals(name)) {
            name = "http://schemas.xmlsoap.org/wsdl/soap/http?mtom=true";
        } else if ("##SOAP12_HTTP".equals(name)) {
            name = "http://www.w3.org/2003/05/soap/bindings/HTTP/";
        } else if ("##SOAP12_HTTP_MTOM".equals(name)) {
            name = "http://www.w3.org/2003/05/soap/bindings/HTTP/?mtom=true";
        } else if ("##XML_HTTP".equals(name)) {
            name = "http://www.w3.org/2004/08/wsdl/http";
        }
        return name.contains(id);
    }


> Wrong method implementation in AnnotationHandlerChainBuilder
> ------------------------------------------------------------
>
>                 Key: CXF-1623
>                 URL: https://issues.apache.org/jira/browse/CXF-1623
>             Project: CXF
>          Issue Type: Sub-task
>            Reporter: Richard Opalka
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.