[GitHub] [incubator-doris] HangyuanLiu commented on a change in pull request #923: Fix concat_ws return null when argument is null

[GitBox <gi...@apache.org>]

HangyuanLiu commented on a change in pull request #923: Fix concat_ws return null when argument is null
URL: https://github.com/apache/incubator-doris/pull/923#discussion_r275237944
 
 

 ##########
 File path: be/src/exprs/string_functions.cpp
 ##########
 @@ -516,17 +516,17 @@ StringVal StringFunctions::concat_ws(
         return strs[0];
     }
 
-    if (strs[0].is_null) {
+    if (strs[0].is_null && 0 == sep.len) {
 
 Review comment:
   Fix done, Sorry~

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org