You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by bo...@apache.org on 2013/11/12 23:27:31 UTC
[2/2] android commit: Fixing plugins configuration,
Device shouldn't be checked in here
Fixing plugins configuration, Device shouldn't be checked in here
Project: http://git-wip-us.apache.org/repos/asf/cordova-android/repo
Commit: http://git-wip-us.apache.org/repos/asf/cordova-android/commit/e5b68f4a
Tree: http://git-wip-us.apache.org/repos/asf/cordova-android/tree/e5b68f4a
Diff: http://git-wip-us.apache.org/repos/asf/cordova-android/diff/e5b68f4a
Branch: refs/heads/master
Commit: e5b68f4a3c44064e5b20d6d6edc4479aee336ccb
Parents: 95babc0
Author: Joe Bowser <bo...@apache.org>
Authored: Tue Nov 12 14:27:09 2013 -0800
Committer: Joe Bowser <bo...@apache.org>
Committed: Tue Nov 12 14:27:09 2013 -0800
----------------------------------------------------------------------
test/assets/www/cordova_plugins.js | 10 +--
.../org.apache.cordova.device/www/device.js | 78 --------------------
test/res/xml/config.xml | 5 +-
3 files changed, 2 insertions(+), 91 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cordova-android/blob/e5b68f4a/test/assets/www/cordova_plugins.js
----------------------------------------------------------------------
diff --git a/test/assets/www/cordova_plugins.js b/test/assets/www/cordova_plugins.js
index f23dd64..fbe1f44 100644
--- a/test/assets/www/cordova_plugins.js
+++ b/test/assets/www/cordova_plugins.js
@@ -1,11 +1,3 @@
cordova.define('cordova/plugin_list', function(require, exports, module) {
-module.exports = [
- {
- "file": "plugins/org.apache.cordova.device/www/device.js",
- "id": "org.apache.cordova.device.device",
- "clobbers": [
- "device"
- ]
- }
-]
+module.exports = []
});
\ No newline at end of file
http://git-wip-us.apache.org/repos/asf/cordova-android/blob/e5b68f4a/test/assets/www/plugins/org.apache.cordova.device/www/device.js
----------------------------------------------------------------------
diff --git a/test/assets/www/plugins/org.apache.cordova.device/www/device.js b/test/assets/www/plugins/org.apache.cordova.device/www/device.js
deleted file mode 100644
index c0697f6..0000000
--- a/test/assets/www/plugins/org.apache.cordova.device/www/device.js
+++ /dev/null
@@ -1,78 +0,0 @@
-cordova.define("org.apache.cordova.device.device", function(require, exports, module) {/*
- *
- * Licensed to the Apache Software Foundation (ASF) under one
- * or more contributor license agreements. See the NOTICE file
- * distributed with this work for additional information
- * regarding copyright ownership. The ASF licenses this file
- * to you under the Apache License, Version 2.0 (the
- * "License"); you may not use this file except in compliance
- * with the License. You may obtain a copy of the License at
- *
- * http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing,
- * software distributed under the License is distributed on an
- * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
- * KIND, either express or implied. See the License for the
- * specific language governing permissions and limitations
- * under the License.
- *
-*/
-
-var argscheck = require('cordova/argscheck'),
- channel = require('cordova/channel'),
- utils = require('cordova/utils'),
- exec = require('cordova/exec'),
- cordova = require('cordova');
-
-channel.createSticky('onCordovaInfoReady');
-// Tell cordova channel to wait on the CordovaInfoReady event
-channel.waitForInitialization('onCordovaInfoReady');
-
-/**
- * This represents the mobile device, and provides properties for inspecting the model, version, UUID of the
- * phone, etc.
- * @constructor
- */
-function Device() {
- this.available = false;
- this.platform = null;
- this.version = null;
- this.uuid = null;
- this.cordova = null;
- this.model = null;
-
- var me = this;
-
- channel.onCordovaReady.subscribe(function() {
- me.getInfo(function(info) {
- //ignoring info.cordova returning from native, we should use value from cordova.version defined in cordova.js
- //TODO: CB-5105 native implementations should not return info.cordova
- var buildLabel = cordova.version;
- me.available = true;
- me.platform = info.platform;
- me.version = info.version;
- me.uuid = info.uuid;
- me.cordova = buildLabel;
- me.model = info.model;
- channel.onCordovaInfoReady.fire();
- },function(e) {
- me.available = false;
- utils.alert("[ERROR] Error initializing Cordova: " + e);
- });
- });
-}
-
-/**
- * Get device info
- *
- * @param {Function} successCallback The function to call when the heading data is available
- * @param {Function} errorCallback The function to call when there is an error getting the heading data. (OPTIONAL)
- */
-Device.prototype.getInfo = function(successCallback, errorCallback) {
- argscheck.checkArgs('fF', 'Device.getInfo', arguments);
- exec(successCallback, errorCallback, "Device", "getDeviceInfo", []);
-};
-
-module.exports = new Device();
-});
http://git-wip-us.apache.org/repos/asf/cordova-android/blob/e5b68f4a/test/res/xml/config.xml
----------------------------------------------------------------------
diff --git a/test/res/xml/config.xml b/test/res/xml/config.xml
index 6988887..24fb933 100644
--- a/test/res/xml/config.xml
+++ b/test/res/xml/config.xml
@@ -4,7 +4,7 @@
<description>
A sample Apache Cordova application that responds to the deviceready event.
</description>
- <author href="http://cordova.io" email="dev@cordova.apache.org">
+ <author email="dev@cordova.apache.org" href="http://cordova.io">
Apache Cordova Team
</author>
<access origin="*.apache.org" />
@@ -18,7 +18,4 @@
<feature name="App">
<param name="android-package" value="org.apache.cordova.App" />
</feature>
- <feature name="Device">
- <param name="android-package" value="org.apache.cordova.device.Device" />
- </feature>
</widget>