You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by Kirby1337 <gi...@git.apache.org> on 2014/05/08 16:06:02 UTC

[GitHub] thrift pull request: TypeScript extension for Thrift Compiler (THR...

GitHub user Kirby1337 opened a pull request:

    https://github.com/apache/thrift/pull/119

    TypeScript extension for Thrift Compiler (THRIFT-2522)

    Add the possibility to generate TypeScript Definition Files in addition to the generated JavaScript code.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/Kirby1337/thrift typescript

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/119.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #119
    
----
commit 4e4ca3619bc4e15939d32f6b545c78fc2046f6b9
Author: Pascal Schweizer <pa...@hispeed.ch>
Date:   2014-03-21T16:18:59Z

    added TypeScript Definition File generation
    currently creates modules, enums, consts & structs/exceptions

commit 9846cf2d9d6954d5a4334b95556b37844b87e864
Author: Pascal Schweizer <pa...@hispeed.ch>
Date:   2014-03-24T15:53:47Z

    added TypeScript Definition File generation for services
    fixed some bugs

commit c0e428bc81e77b28a0182e67c09616d0d5dfe6df
Author: Pascal Schweizer <pa...@hispeed.ch>
Date:   2014-03-25T13:19:43Z

    added Thrift IDL documentation to TypeScript definitions
    minor restyling of the definitions

commit b144852e1054be616df9313ecf37ac598853584b
Author: Pascal Schweizer <pa...@hispeed.ch>
Date:   2014-03-25T15:02:18Z

    added TypeScript style enums to generated JavaScript code

commit defd2437a0fd2097728e1df84afb43b809c4f18d
Author: Pascal Schweizer <pa...@hispeed.ch>
Date:   2014-03-25T15:23:45Z

    removed TypeScript includes/references (not needed in .d.ts files)

commit a61e322f9191dff504a857cf4dbdbd4e41a9e1a9
Author: Kirby1337 <pa...@hispeed.ch>
Date:   2014-03-25T22:59:19Z

    modified type generation for TS lists, sets & maps

commit 4482e5c45725e4d9ed04b2eaa0392144b0003861
Author: Pascal Schweizer <pa...@hispeed.ch>
Date:   2014-03-27T07:46:37Z

    fixed map type definition (any doesn't work as keytype)

commit 64b624c94f63f907397517f03903e5b4d56b2f51
Author: Pascal Schweizer <pa...@hispeed.ch>
Date:   2014-03-27T08:44:38Z

    modified output directory for TypeScript Definition Files

commit 3fe4ed62c763646d9598d7cf2dfe0b475b05e789
Author: Pascal Schweizer <pa...@hispeed.ch>
Date:   2014-03-27T09:03:24Z

    fixed TS outdir bug with parameter -out

commit 044377d449abd835dbb8f1c5ec5daa6b4ed98c43
Author: Pascal Schweizer <pa...@hispeed.ch>
Date:   2014-04-01T06:46:53Z

    added recursive TS type generation for lists, sets & maps
    revised comments
    fixed a few bugs

commit 2e4442dc844fb92f69fee038056066fbbac4d3b0
Author: Pascal Schweizer <pa...@hispeed.ch>
Date:   2014-04-10T14:57:59Z

    fixed type generation for maps
    added reference tag for services which extend another one

commit 0d691e6db0fa124561b2680ee824304aa302f9af
Author: Pascal Schweizer <pa...@hispeed.ch>
Date:   2014-04-11T11:29:08Z

    bool is now interpreted as any in TypeScript

commit e968fe18fc870a1f51f15f750fe9ff49bbc694b4
Author: Pascal Schweizer <pa...@hispeed.ch>
Date:   2014-05-08T12:48:16Z

    lineending fix dos -> unix

commit 5583c6f2e455937fd5270c4b9c61c256f4a64508
Author: Pascal Schweizer <pa...@hispeed.ch>
Date:   2014-05-08T13:58:34Z

    added TypeScript definitions for JS library

commit e39e3cbf225b298688efd81fbcc3a13b550fa9e5
Author: Pascal Schweizer <pa...@hispeed.ch>
Date:   2014-05-08T14:00:18Z

    Merge https://github.com/apache/thrift

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: TypeScript extension for Thrift Compiler (THR...

Posted by Kirby1337 <gi...@git.apache.org>.
Github user Kirby1337 closed the pull request at:

    https://github.com/apache/thrift/pull/119


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] thrift pull request: TypeScript extension for Thrift Compiler (THR...

Posted by bufferoverflow <gi...@git.apache.org>.
Github user bufferoverflow commented on the pull request:

    https://github.com/apache/thrift/pull/119#issuecomment-42712665
  
    Great work Pascal!
    
    thanks for adding the required topic:
    https://issues.apache.org/jira/browse/THRIFT-2522
    
    could you please
    - add the apache license header to the lib/ts/thrift.d.ts file
    - close this pull request
    - create a new single commit with title *THRIFT-2522 TypeScript extension for Thrift Compiler*
    - create a new pull request with this commit or attach the patch to THRIFT-2522
    
    thanks
    -roger


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---