You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2017/12/28 19:34:32 UTC
[GitHub] bhavinthaker commented on a change in pull request #9218: Update mkl
bhavinthaker commented on a change in pull request #9218: Update mkl
URL: https://github.com/apache/incubator-mxnet/pull/9218#discussion_r158987932
##########
File path: prepare_mkl.sh
##########
@@ -75,16 +75,16 @@ MXNET_ROOT=`dirname $0`
USE_MKLML=0
# NOTE: if you update the following line, please also update the dockerfile at
# tests/ci_build/Dockerfile.mkl
-VERSION_MATCH=20170908
+VERSION_MATCH=20171227
PLATFORM=$(uname)
if [ $PLATFORM == "Darwin" ]; then
INFIX=mac
elif [ $PLATFORM == "Linux" ]; then
INFIX=lnx
fi
-ARCHIVE_BASENAME=mklml_${INFIX}_2018.0.20170908.tgz
+ARCHIVE_BASENAME=mklml_${INFIX}_2018.0.1.20171227.tgz
Review comment:
It would help to use ${VERSION_MATCH} here so that the version needs to be defined in only one place.
All other changes look fine to me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services