You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rave.apache.org by "Raminderjeet Singh (JIRA)" <ji...@apache.org> on 2012/06/05 17:45:23 UTC
[jira] [Created] (RAVE-654) Empty comment is allowed in add widget
submit page.
Raminderjeet Singh created RAVE-654:
---------------------------------------
Summary: Empty comment is allowed in add widget submit page.
Key: RAVE-654
URL: https://issues.apache.org/jira/browse/RAVE-654
Project: Rave
Issue Type: Bug
Components: rave-web
Affects Versions: 0.12
Reporter: Raminderjeet Singh
Priority: Trivial
Empty comment is allowed after you add a new gadget.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (RAVE-654) Empty comment is allowed in add widget
submit page.
Posted by "Daniel Gornstein (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Gornstein updated RAVE-654:
----------------------------------
Attachment: fixEmptyCommentsOnWidgets(Rave-654).patch
This patch does not allow empty comments to be posted on a widget in the store. If you try to post an empty comment an alert box pops up asking you to please enter text into the comment field.
Also added a line which clears out the comment field after posting a comment. Before, the same text you just submitted was still populated in the comment box.
> Empty comment is allowed in add widget submit page.
> ---------------------------------------------------
>
> Key: RAVE-654
> URL: https://issues.apache.org/jira/browse/RAVE-654
> Project: Rave
> Issue Type: Bug
> Components: rave-web
> Affects Versions: 0.12
> Reporter: Raminderjeet Singh
> Assignee: Daniel Gornstein
> Priority: Trivial
> Attachments: Rave654.patch, fixEmptyCommentsOnWidgets(Rave-654).patch
>
>
> Empty comment is allowed after you add a new gadget.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (RAVE-654) Empty comment is allowed in add widget
submit page.
Posted by "Viknes B (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Viknes B updated RAVE-654:
--------------------------
Attachment: (was: RAVE-654.patch)
> Empty comment is allowed in add widget submit page.
> ---------------------------------------------------
>
> Key: RAVE-654
> URL: https://issues.apache.org/jira/browse/RAVE-654
> Project: Rave
> Issue Type: Bug
> Components: rave-web
> Affects Versions: 0.12
> Reporter: Raminderjeet Singh
> Priority: Trivial
> Attachments: Rave654.patch
>
>
> Empty comment is allowed after you add a new gadget.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-654) Empty comment is allowed in add
widget submit page.
Posted by "Viknes B (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294653#comment-13294653 ]
Viknes B commented on RAVE-654:
-------------------------------
I am trying to disable the button if the text box does not contain any text but using this piece of code doesnt disable the code
$(".commentNewButton").button().attr('disabled','disabled');
or
$(".commentNewButton").button().prop('disabled','disabled');
or
$(".commentNewButton").attr('disabled','disabled');
or
$(".commentNewButton").prop('disabled','disabled');
comments/suggestions pls
> Empty comment is allowed in add widget submit page.
> ---------------------------------------------------
>
> Key: RAVE-654
> URL: https://issues.apache.org/jira/browse/RAVE-654
> Project: Rave
> Issue Type: Bug
> Components: rave-web
> Affects Versions: 0.12
> Reporter: Raminderjeet Singh
> Priority: Trivial
> Attachments: Rave654.patch
>
>
> Empty comment is allowed after you add a new gadget.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (RAVE-654) Empty comment is allowed in add widget
submit page.
Posted by "Viknes B (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Viknes B updated RAVE-654:
--------------------------
Attachment: Rave654.patch
> Empty comment is allowed in add widget submit page.
> ---------------------------------------------------
>
> Key: RAVE-654
> URL: https://issues.apache.org/jira/browse/RAVE-654
> Project: Rave
> Issue Type: Bug
> Components: rave-web
> Affects Versions: 0.12
> Reporter: Raminderjeet Singh
> Priority: Trivial
> Attachments: Rave654.patch
>
>
> Empty comment is allowed after you add a new gadget.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (RAVE-654) Empty comment is allowed in add widget
submit page.
Posted by "Viknes B (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Viknes B updated RAVE-654:
--------------------------
Attachment: RAVE-654.patch
> Empty comment is allowed in add widget submit page.
> ---------------------------------------------------
>
> Key: RAVE-654
> URL: https://issues.apache.org/jira/browse/RAVE-654
> Project: Rave
> Issue Type: Bug
> Components: rave-web
> Affects Versions: 0.12
> Reporter: Raminderjeet Singh
> Priority: Trivial
> Attachments: RAVE-654.patch
>
>
> Empty comment is allowed after you add a new gadget.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (RAVE-654) Empty comment is allowed in add widget
submit page.
Posted by "Daniel Gornstein (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Gornstein updated RAVE-654:
----------------------------------
Attachment: fixEmptyCommentsOnWidgets(Rave-654)-2.patch
Changed patch to use html5 required tag to alert users that the comment field needs to be filled out, instead of an alert pop-up
> Empty comment is allowed in add widget submit page.
> ---------------------------------------------------
>
> Key: RAVE-654
> URL: https://issues.apache.org/jira/browse/RAVE-654
> Project: Rave
> Issue Type: Bug
> Components: rave-web
> Affects Versions: 0.12
> Reporter: Raminderjeet Singh
> Assignee: Daniel Gornstein
> Priority: Trivial
> Attachments: fixEmptyCommentsOnWidgets(Rave-654)-2.patch, fixEmptyCommentsOnWidgets(Rave-654).patch, Rave654.patch
>
>
> Empty comment is allowed after you add a new gadget.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (RAVE-654) Empty comment is allowed in add widget
submit page.
Posted by "Daniel Gornstein (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-654?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Daniel Gornstein reassigned RAVE-654:
-------------------------------------
Assignee: Daniel Gornstein
> Empty comment is allowed in add widget submit page.
> ---------------------------------------------------
>
> Key: RAVE-654
> URL: https://issues.apache.org/jira/browse/RAVE-654
> Project: Rave
> Issue Type: Bug
> Components: rave-web
> Affects Versions: 0.12
> Reporter: Raminderjeet Singh
> Assignee: Daniel Gornstein
> Priority: Trivial
> Attachments: Rave654.patch
>
>
> Empty comment is allowed after you add a new gadget.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (RAVE-654) Empty comment is allowed in add
widget submit page.
Posted by "Raminderjeet Singh (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/RAVE-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294498#comment-13294498 ]
Raminderjeet Singh commented on RAVE-654:
-----------------------------------------
I tried to apply the patch and submit is not working after button gets is enabled.
> Empty comment is allowed in add widget submit page.
> ---------------------------------------------------
>
> Key: RAVE-654
> URL: https://issues.apache.org/jira/browse/RAVE-654
> Project: Rave
> Issue Type: Bug
> Components: rave-web
> Affects Versions: 0.12
> Reporter: Raminderjeet Singh
> Priority: Trivial
> Attachments: Rave654.patch
>
>
> Empty comment is allowed after you add a new gadget.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira