You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/07 11:31:55 UTC
[GitHub] [apisix-dashboard] imjoey opened a new pull request #1454: backport: fix: the git commit hash in the docker is empty string (#1446)
imjoey opened a new pull request #1454:
URL: https://github.com/apache/apisix-dashboard/pull/1454
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [x] Backport patches
___
### Backport patches
- Why need to backport?
It's included in 2.4 release with the plan.
> In the docker build, the compressed package of github is directly downloaded, which does not contain git information, that causes the git commit hash to be empty string. Use git repo source code to build docker image.
- Source branch
`master`
- Related commits and pull requests
https://github.com/apache/apisix-dashboard/pull/1446
- Target branch
`v2.4`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran merged pull request #1454: backport: fix: the git commit hash in the docker is empty string (#1446)
Posted by GitBox <gi...@apache.org>.
liuxiran merged pull request #1454:
URL: https://github.com/apache/apisix-dashboard/pull/1454
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on pull request #1454: backport: fix: the git commit hash in the docker is empty string (#1446)
Posted by GitBox <gi...@apache.org>.
imjoey commented on pull request #1454:
URL: https://github.com/apache/apisix-dashboard/pull/1454#issuecomment-774658567
ping @juzhiyuan @nic-chen @liuxiran for reviewing this backport PR. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org