You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/24 08:16:06 UTC

[GitHub] [flink-kubernetes-operator] yangjf2019 opened a new pull request, #451: [FLINK-30186] Bump Flink version to 1.15.3

yangjf2019 opened a new pull request, #451:
URL: https://github.com/apache/flink-kubernetes-operator/pull/451

   <!--
   *Thank you very much for contributing to the Apache Flink Kubernetes Operator - we are happy that you want to help us improve the project. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
     
     - Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
     Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix][docs] Fix typo in event time introduction` or `[hotfix][javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
   
     - Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
     
     - Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can read more on how we use GitHub Actions for CI [here](https://nightlies.apache.org/flink/flink-kubernetes-operator-docs-main/docs/development/guide/#cicd).
   
     - Each pull request should address only one issue, not mix up code from multiple issues.
     
     - Each commit in the pull request has a meaningful commit message (including the JIRA id)
   
     - Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
   
   
   **(The sections below can be removed for hotfixes of typos)**
   -->
   
   ## What is the purpose of the change
   
   * Bump Flink version to 1.15.3.
   
   
   ## Brief change log
   
   * I modified some files in the project.
   
   ## Verifying this change
   <!--
   Please make sure both new and modified tests in this PR follows the conventions defined in our code quality guide: https://flink.apache.org/contributing/code-style-and-quality-common.html#testing
   -->
   *I checked the changes.*
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changes to the `CustomResourceDescriptors`: (no)
     - Core observer or reconciler logic that is regularly executed: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (no)
     
   Hi,@gyfora please take a look ,thank you very much!
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-kubernetes-operator] gyfora merged pull request #451: [FLINK-30186] Bump Flink version to 1.15.3

Posted by GitBox <gi...@apache.org>.
gyfora merged PR #451:
URL: https://github.com/apache/flink-kubernetes-operator/pull/451


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #451: [FLINK-30186] Bump Flink version to 1.15.3

Posted by GitBox <gi...@apache.org>.
gyfora commented on PR #451:
URL: https://github.com/apache/flink-kubernetes-operator/pull/451#issuecomment-1326225663

   The change looks good, I will retrigger the CI in a few hours.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-kubernetes-operator] yangjf2019 commented on pull request #451: [FLINK-30186] Bump Flink version to 1.15.3

Posted by GitBox <gi...@apache.org>.
yangjf2019 commented on PR #451:
URL: https://github.com/apache/flink-kubernetes-operator/pull/451#issuecomment-1328445247

   Hi, @gyfora The central repository has generated the corresponding dependencies, please trigger the CI again, thank you!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-kubernetes-operator] yangjf2019 commented on pull request #451: [FLINK-30186] Bump Flink version to 1.15.3

Posted by GitBox <gi...@apache.org>.
yangjf2019 commented on PR #451:
URL: https://github.com/apache/flink-kubernetes-operator/pull/451#issuecomment-1331638731

   Okay, thanks, I'll take a look as soon as I can.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #451: [FLINK-30186] Bump Flink version to 1.15.3

Posted by GitBox <gi...@apache.org>.
gyfora commented on PR #451:
URL: https://github.com/apache/flink-kubernetes-operator/pull/451#issuecomment-1330717183

   > Yes, I think it can, in that case, how should we adjust it please?
   
   You can look at the CI config to get an idea:
   https://github.com/apache/flink-kubernetes-operator/blob/main/.github/workflows/ci.yml#L110
   https://github.com/apache/flink-kubernetes-operator/blob/main/.github/workflows/ci.yml#L159-L161
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-kubernetes-operator] mbalassi commented on pull request #451: [FLINK-30186] Bump Flink version to 1.15.3

Posted by GitBox <gi...@apache.org>.
mbalassi commented on PR #451:
URL: https://github.com/apache/flink-kubernetes-operator/pull/451#issuecomment-1328874737

   Thanks @yangjf2019, retriggered the CI.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-kubernetes-operator] yangjf2019 commented on pull request #451: [FLINK-30186] Bump Flink version to 1.15.3

Posted by GitBox <gi...@apache.org>.
yangjf2019 commented on PR #451:
URL: https://github.com/apache/flink-kubernetes-operator/pull/451#issuecomment-1330698087

   Yes, I think it can, in that case, how should we adjust it please?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #451: [FLINK-30186] Bump Flink version to 1.15.3

Posted by GitBox <gi...@apache.org>.
gyfora commented on PR #451:
URL: https://github.com/apache/flink-kubernetes-operator/pull/451#issuecomment-1330633259

   @yangjf2019 seems like the 1.13 e2e tests started to fail on a noclassdef found error. We should probably use the respective example jars there from the 1.13 version not the latest.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-kubernetes-operator] yangjf2019 commented on pull request #451: [FLINK-30186] Bump Flink version to 1.15.3

Posted by GitBox <gi...@apache.org>.
yangjf2019 commented on PR #451:
URL: https://github.com/apache/flink-kubernetes-operator/pull/451#issuecomment-1326112139

   The central repository has not yet generated the org.apache.flink:flink-kubernetes:1.15.2 dependency, so we may have to wait a bit.
   <img width="875" alt="image" src="https://user-images.githubusercontent.com/54518670/203731763-5c20bd88-2296-4967-9f40-4ac74391cede.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-kubernetes-operator] gyfora commented on pull request #451: [FLINK-30186] Bump Flink version to 1.15.3

Posted by GitBox <gi...@apache.org>.
gyfora commented on PR #451:
URL: https://github.com/apache/flink-kubernetes-operator/pull/451#issuecomment-1330682062

   @yangjf2019 do you think we could modify the logic so that we pick the jars based on Flink version, similar to how change other parts of the spec?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-kubernetes-operator] yangjf2019 commented on pull request #451: [FLINK-30186] Bump Flink version to 1.15.3

Posted by GitBox <gi...@apache.org>.
yangjf2019 commented on PR #451:
URL: https://github.com/apache/flink-kubernetes-operator/pull/451#issuecomment-1330670947

   Okay,I revert it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [flink-kubernetes-operator] yangjf2019 commented on pull request #451: [FLINK-30186] Bump Flink version to 1.15.3

Posted by GitBox <gi...@apache.org>.
yangjf2019 commented on PR #451:
URL: https://github.com/apache/flink-kubernetes-operator/pull/451#issuecomment-1334991547

   @gyfora  I'm sorry,I didn't think of a good way to handle it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org