You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/08/22 10:46:19 UTC
[GitHub] [doris] jacktengg opened a new pull request, #11967: [bugfix](dict) fix coredump of dict colum range predicate when there …
jacktengg opened a new pull request, #11967:
URL: https://github.com/apache/doris/pull/11967
…is null value
# Proposed changes
Issue Number: close #11966
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] yiguolei merged pull request #11967: [bugfix](dict) fix coredump of dict colum range predicate when there …
Posted by GitBox <gi...@apache.org>.
yiguolei merged PR #11967:
URL: https://github.com/apache/doris/pull/11967
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] jacktengg commented on pull request #11967: [bugfix](dict) fix coredump of dict colum range predicate when there …
Posted by GitBox <gi...@apache.org>.
jacktengg commented on PR #11967:
URL: https://github.com/apache/doris/pull/11967#issuecomment-1222406111
> > > How to reproduce the problem? I used the regression test case but it didn't reproduce.
> >
> >
> > See Reproduce in issue
>
> <img alt="image" width="820" src="https://user-images.githubusercontent.com/21984011/185928196-4c788e8c-6562-4324-b05a-70679b71f22b.png">
>
> I used the master [0c5b4ec](https://github.com/apache/doris/commit/0c5b4ecc7cc46e2b014bb1f4c909be04f736c54a) version, but still can't reproduce. 😅
Need enable vec engine adn storage vectorization. I just tried and can reproduce it...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zenoyang commented on pull request #11967: [bugfix](dict) fix coredump of dict colum range predicate when there …
Posted by GitBox <gi...@apache.org>.
zenoyang commented on PR #11967:
URL: https://github.com/apache/doris/pull/11967#issuecomment-1223707947
After testing and analysis, in release and debug mode, coredump does not appear, and correct results can be obtained, although there are some problems with intermediate results. In ASAN mode, it will coredump.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zenoyang commented on pull request #11967: [bugfix](dict) fix coredump of dict colum range predicate when there …
Posted by GitBox <gi...@apache.org>.
zenoyang commented on PR #11967:
URL: https://github.com/apache/doris/pull/11967#issuecomment-1222271485
How to reproduce the problem? I used the regression test case but it didn't reproduce.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] jacktengg commented on pull request #11967: [bugfix](dict) fix coredump of dict colum range predicate when there …
Posted by GitBox <gi...@apache.org>.
jacktengg commented on PR #11967:
URL: https://github.com/apache/doris/pull/11967#issuecomment-1222288908
> How to reproduce the problem? I used the regression test case but it didn't reproduce.
See Reproduce in issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11967: [bugfix](dict) fix coredump of dict colum range predicate when there …
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11967:
URL: https://github.com/apache/doris/pull/11967#issuecomment-1222386083
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] jacktengg commented on pull request #11967: [bugfix](dict) fix coredump of dict colum range predicate when there …
Posted by GitBox <gi...@apache.org>.
jacktengg commented on PR #11967:
URL: https://github.com/apache/doris/pull/11967#issuecomment-1222288069
>
see issue
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] jacktengg commented on pull request #11967: [bugfix](dict) fix coredump of dict colum range predicate when there …
Posted by GitBox <gi...@apache.org>.
jacktengg commented on PR #11967:
URL: https://github.com/apache/doris/pull/11967#issuecomment-1223610514
> > > How to reproduce the problem? I used the regression test case but it didn't reproduce.
> >
> >
> > See Reproduce in issue
>
> <img alt="image" width="820" src="https://user-images.githubusercontent.com/21984011/185928196-4c788e8c-6562-4324-b05a-70679b71f22b.png">
>
> I used the master [0c5b4ec](https://github.com/apache/doris/commit/0c5b4ecc7cc46e2b014bb1f4c909be04f736c54a) version, but still can't reproduce. 😅
Seems Release build runs OK, but the original code is problematic. I added log in function `convert_code` and tested as described in the issue, the log print:
```
I0823 13:00:11.292980 184748 column_dictionary.h:396] code: -1, ret code: 22005
I0823 13:00:11.292997 184748 column_dictionary.h:396] code: 0, ret code: 0
```
The vector _code_convert_table is indexed with `-1` and the return value is random.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #11967: [bugfix](dict) fix coredump of dict colum range predicate when there …
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #11967:
URL: https://github.com/apache/doris/pull/11967#issuecomment-1222386041
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] zenoyang commented on pull request #11967: [bugfix](dict) fix coredump of dict colum range predicate when there …
Posted by GitBox <gi...@apache.org>.
zenoyang commented on PR #11967:
URL: https://github.com/apache/doris/pull/11967#issuecomment-1222334729
> > How to reproduce the problem? I used the regression test case but it didn't reproduce.
>
> See Reproduce in issue
<img width="820" alt="image" src="https://user-images.githubusercontent.com/21984011/185928196-4c788e8c-6562-4324-b05a-70679b71f22b.png">
I used the master 0c5b4ec version, but still can't reproduce. 😅
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org