[GitHub] [calcite] JiajunBernoulli commented on a diff in pull request #2811: [CALCITE-5156] Support implicit type cast for IN Sub-query

[GitBox <gi...@apache.org>]

JiajunBernoulli commented on code in PR #2811:
URL: https://github.com/apache/calcite/pull/2811#discussion_r878809082


##########
core/src/main/java/org/apache/calcite/sql/validate/implicit/AbstractTypeCoercion.java:
##########
@@ -257,15 +257,6 @@ protected boolean needToCast(SqlValidatorScope scope, SqlNode node, RelDataType
       return false;
     }
 
-    // No need to cast if the source type precedence list

Review Comment:
   I found that you only changed the conversion rules between tinyint, int and bigint. Do you want to support more types for IN Sub-query?  For example:
   ```
     @Test void testInSubQuery() {
       sql("select * from t1 where t1_bigint in (select t1_decimal from t1)")
           .withExpand(false)
           .ok();
     }
   ```
   > Learn from you.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org