You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Michael Brown (Code Review)" <ge...@cloudera.org> on 2019/02/05 17:57:49 UTC

[Impala-ASF-CR] IMPALA-8091 addendum: use absolute path for ntp-wait 

Michael Brown has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12369


Change subject: IMPALA-8091 addendum: use absolute path for ntp-wait
......................................................................

IMPALA-8091 addendum: use absolute path for ntp-wait

While ntp-wait is in the default $PATH on Ubuntu, it's not on CentOS.
Use the absolute path of the binary (same in both flavors).

Testing:
- Ran privately on CentOS both with and without ntp-wait installed; GVO
  will cover Ubuntu.

Change-Id: I5d709d121a71e62b8ee4027db81b53108f389fdd
---
M testdata/cluster/admin
1 file changed, 4 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/12369/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12369
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5d709d121a71e62b8ee4027db81b53108f389fdd
Gerrit-Change-Number: 12369
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Brown <mi...@cloudera.com>

[Impala-ASF-CR] IMPALA-8091 addendum: use absolute path for ntp-wait

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12369 )

Change subject: IMPALA-8091 addendum: use absolute path for ntp-wait
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3720/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/12369
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d709d121a71e62b8ee4027db81b53108f389fdd
Gerrit-Change-Number: 12369
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Feb 2019 18:03:57 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8091 addendum: use absolute path for ntp-wait

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12369 )

Change subject: IMPALA-8091 addendum: use absolute path for ntp-wait
......................................................................

IMPALA-8091 addendum: use absolute path for ntp-wait

While ntp-wait is in the default $PATH on Ubuntu, it's not on CentOS.
Use the absolute path of the binary (same in both flavors).

Testing:
- Ran privately on CentOS both with and without ntp-wait installed; GVO
  will cover Ubuntu.

Change-Id: I5d709d121a71e62b8ee4027db81b53108f389fdd
Reviewed-on: http://gerrit.cloudera.org:8080/12369
Reviewed-by: Philip Zeyliger <ph...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/cluster/admin
1 file changed, 4 insertions(+), 2 deletions(-)

Approvals:
  Philip Zeyliger: Looks good to me, approved
  Impala Public Jenkins: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/12369
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5d709d121a71e62b8ee4027db81b53108f389fdd
Gerrit-Change-Number: 12369
Gerrit-PatchSet: 2
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>

[Impala-ASF-CR] IMPALA-8091 addendum: use absolute path for ntp-wait

Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12369 )

Change subject: IMPALA-8091 addendum: use absolute path for ntp-wait
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12369
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d709d121a71e62b8ee4027db81b53108f389fdd
Gerrit-Change-Number: 12369
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Feb 2019 17:59:11 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8091 addendum: use absolute path for ntp-wait

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12369 )

Change subject: IMPALA-8091 addendum: use absolute path for ntp-wait
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/1991/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12369
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d709d121a71e62b8ee4027db81b53108f389fdd
Gerrit-Change-Number: 12369
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Feb 2019 18:27:05 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8091 addendum: use absolute path for ntp-wait

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12369 )

Change subject: IMPALA-8091 addendum: use absolute path for ntp-wait
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/12369
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d709d121a71e62b8ee4027db81b53108f389fdd
Gerrit-Change-Number: 12369
Gerrit-PatchSet: 1
Gerrit-Owner: Michael Brown <mi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Comment-Date: Tue, 05 Feb 2019 22:04:43 +0000
Gerrit-HasComments: No