You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Sandeep Tata (JIRA)" <ji...@apache.org> on 2009/10/21 02:13:59 UTC
[jira] Created: (CASSANDRA-502) Improve BootStrapperTest
Improve BootStrapperTest
------------------------
Key: CASSANDRA-502
URL: https://issues.apache.org/jira/browse/CASSANDRA-502
Project: Cassandra
Issue Type: Improvement
Components: Core
Affects Versions: 0.5
Environment: all
Reporter: Sandeep Tata
Assignee: Sandeep Tata
Priority: Minor
Fix For: 0.5
BootStrapper test should insert the tokens as "bootstrapping" so tokenMetadata is in a "real" state before running getRangesWithSourceTarget().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-502) Improve BootStrapperTest
Posted by "Sandeep Tata (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sandeep Tata updated CASSANDRA-502:
-----------------------------------
Attachment: CASSANDRA-502-v1.patch
Refactored bootstrapper test to add nodes in bootstrap state while checking for src->target calculations
> Improve BootStrapperTest
> ------------------------
>
> Key: CASSANDRA-502
> URL: https://issues.apache.org/jira/browse/CASSANDRA-502
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.5
> Environment: all
> Reporter: Sandeep Tata
> Assignee: Sandeep Tata
> Priority: Minor
> Fix For: 0.5
>
> Attachments: CASSANDRA-502-v1.patch
>
>
> BootStrapper test should insert the tokens as "bootstrapping" so tokenMetadata is in a "real" state before running getRangesWithSourceTarget().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-502) Improve BootStrapperTest
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-502?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-502:
-------------------------------------
Component/s: (was: Core)
Tools
Assignee: (was: Sandeep Tata)
> Improve BootStrapperTest
> ------------------------
>
> Key: CASSANDRA-502
> URL: https://issues.apache.org/jira/browse/CASSANDRA-502
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Affects Versions: 0.5
> Environment: all
> Reporter: Sandeep Tata
> Priority: Minor
> Fix For: 0.5
>
> Attachments: CASSANDRA-502-v1.patch
>
>
> BootStrapper test should insert the tokens as "bootstrapping" so tokenMetadata is in a "real" state before running getRangesWithSourceTarget().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-502) Improve BootStrapperTest
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768298#action_12768298 ]
Jonathan Ellis commented on CASSANDRA-502:
------------------------------------------
is this supposed to apply to 0.4?
> Improve BootStrapperTest
> ------------------------
>
> Key: CASSANDRA-502
> URL: https://issues.apache.org/jira/browse/CASSANDRA-502
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.5
> Environment: all
> Reporter: Sandeep Tata
> Assignee: Sandeep Tata
> Priority: Minor
> Fix For: 0.5
>
> Attachments: CASSANDRA-502-v1.patch
>
>
> BootStrapper test should insert the tokens as "bootstrapping" so tokenMetadata is in a "real" state before running getRangesWithSourceTarget().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-502) Improve BootStrapperTest
Posted by "Sandeep Tata (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768045#action_12768045 ]
Sandeep Tata commented on CASSANDRA-502:
----------------------------------------
For the simple case of a 1 node cluster (replication = 1) where you're bootstrapping a second node, the existing code should breaks.
I get an NPE in the bootstrapper thread and the bootstrap actually fails. (Jonathan -- did this case work for you with trunk?)
This patch makes sure you're picking up the nodes that handle new ranges correctly by using constructRangeToEndPointMap(newRanges, newTokenToEndPointMap); instead of the old tokenToEndPointMap which has the new nodes removed by the time you get here.
> Improve BootStrapperTest
> ------------------------
>
> Key: CASSANDRA-502
> URL: https://issues.apache.org/jira/browse/CASSANDRA-502
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.5
> Environment: all
> Reporter: Sandeep Tata
> Assignee: Sandeep Tata
> Priority: Minor
> Fix For: 0.5
>
> Attachments: CASSANDRA-502-v1.patch
>
>
> BootStrapper test should insert the tokens as "bootstrapping" so tokenMetadata is in a "real" state before running getRangesWithSourceTarget().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-502) Improve BootStrapperTest
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768050#action_12768050 ]
Jonathan Ellis commented on CASSANDRA-502:
------------------------------------------
I've been testing growing a four-node cluster to five.
> Improve BootStrapperTest
> ------------------------
>
> Key: CASSANDRA-502
> URL: https://issues.apache.org/jira/browse/CASSANDRA-502
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.5
> Environment: all
> Reporter: Sandeep Tata
> Assignee: Sandeep Tata
> Priority: Minor
> Fix For: 0.5
>
> Attachments: CASSANDRA-502-v1.patch
>
>
> BootStrapper test should insert the tokens as "bootstrapping" so tokenMetadata is in a "real" state before running getRangesWithSourceTarget().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (CASSANDRA-502) Improve
BootStrapperTest
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768298#action_12768298 ]
Jonathan Ellis edited comment on CASSANDRA-502 at 10/21/09 8:46 PM:
--------------------------------------------------------------------
Doesn't apply to either 0.4 or trunk for me
was (Author: jbellis):
is this supposed to apply to 0.4?
> Improve BootStrapperTest
> ------------------------
>
> Key: CASSANDRA-502
> URL: https://issues.apache.org/jira/browse/CASSANDRA-502
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.5
> Environment: all
> Reporter: Sandeep Tata
> Assignee: Sandeep Tata
> Priority: Minor
> Fix For: 0.5
>
> Attachments: CASSANDRA-502-v1.patch
>
>
> BootStrapper test should insert the tokens as "bootstrapping" so tokenMetadata is in a "real" state before running getRangesWithSourceTarget().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-502) Improve BootStrapperTest
Posted by "Sandeep Tata (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768474#action_12768474 ]
Sandeep Tata commented on CASSANDRA-502:
----------------------------------------
Hmm, this was supposed to apply on trunk, I'll rebase and resubmit.
> Improve BootStrapperTest
> ------------------------
>
> Key: CASSANDRA-502
> URL: https://issues.apache.org/jira/browse/CASSANDRA-502
> Project: Cassandra
> Issue Type: Improvement
> Components: Core
> Affects Versions: 0.5
> Environment: all
> Reporter: Sandeep Tata
> Assignee: Sandeep Tata
> Priority: Minor
> Fix For: 0.5
>
> Attachments: CASSANDRA-502-v1.patch
>
>
> BootStrapper test should insert the tokens as "bootstrapping" so tokenMetadata is in a "real" state before running getRangesWithSourceTarget().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-502) Improve BootStrapperTest
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-502?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12770912#action_12770912 ]
Hudson commented on CASSANDRA-502:
----------------------------------
Integrated in Cassandra #241 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/241/])
make BootStrapperTest use of TokenMetadata match actual BootStrapper use better. patch by jbellis for
> Improve BootStrapperTest
> ------------------------
>
> Key: CASSANDRA-502
> URL: https://issues.apache.org/jira/browse/CASSANDRA-502
> Project: Cassandra
> Issue Type: Improvement
> Components: Tools
> Affects Versions: 0.5
> Environment: all
> Reporter: Sandeep Tata
> Priority: Minor
> Fix For: 0.5
>
> Attachments: CASSANDRA-502-v1.patch
>
>
> BootStrapper test should insert the tokens as "bootstrapping" so tokenMetadata is in a "real" state before running getRangesWithSourceTarget().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.