You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-commits@hadoop.apache.org by om...@apache.org on 2008/10/10 17:50:48 UTC

svn commit: r703508 - in /hadoop/core/trunk: ./ src/mapred/org/apache/hadoop/mapred/

Author: omalley
Date: Fri Oct 10 08:50:47 2008
New Revision: 703508

URL: http://svn.apache.org/viewvc?rev=703508&view=rev
Log:
HADOOP-4380. Made several new classes (Child, JVMId, 
JobTrackerInstrumentation, QueueManager, ResourceEstimator, 
TaskTrackerInstrumentation, and TaskTrackerMetricsInst) in 
org.apache.hadoop.mapred  package private instead of public. (omalley)

Modified:
    hadoop/core/trunk/CHANGES.txt
    hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/Child.java
    hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/JVMId.java
    hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/JobTrackerInstrumentation.java
    hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/QueueManager.java
    hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/ResourceEstimator.java
    hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/TaskTrackerInstrumentation.java
    hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/TaskTrackerMetricsInst.java

Modified: hadoop/core/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/CHANGES.txt?rev=703508&r1=703507&r2=703508&view=diff
==============================================================================
--- hadoop/core/trunk/CHANGES.txt (original)
+++ hadoop/core/trunk/CHANGES.txt Fri Oct 10 08:50:47 2008
@@ -525,6 +525,11 @@
     HADOOP-4225. FSEditLog.logOpenFile() should persist accessTime 
     rather than modificationTime. (shv)
 
+    HADOOP-4380. Made several new classes (Child, JVMId, 
+    JobTrackerInstrumentation, QueueManager, ResourceEstimator, 
+    TaskTrackerInstrumentation, and TaskTrackerMetricsInst) in 
+    org.apache.hadoop.mapred  package private instead of public. (omalley)
+
   BUG FIXES
 
     HADOOP-3563.  Refactor the distributed upgrade code so that it is 

Modified: hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/Child.java
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/Child.java?rev=703508&r1=703507&r2=703508&view=diff
==============================================================================
--- hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/Child.java (original)
+++ hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/Child.java Fri Oct 10 08:50:47 2008
@@ -41,7 +41,7 @@
  * The main() for child processes. 
  */
 
-public class Child {
+class Child {
 
   public static final Log LOG =
     LogFactory.getLog(TaskTracker.class);

Modified: hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/JVMId.java
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/JVMId.java?rev=703508&r1=703507&r2=703508&view=diff
==============================================================================
--- hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/JVMId.java (original)
+++ hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/JVMId.java Fri Oct 10 08:50:47 2008
@@ -23,7 +23,7 @@
 import java.io.IOException;
 import java.text.NumberFormat;
 
-public class JVMId extends ID {
+class JVMId extends ID {
   boolean isMap;
   JobID jobId;
   private static final String JVM = "jvm";

Modified: hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/JobTrackerInstrumentation.java
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/JobTrackerInstrumentation.java?rev=703508&r1=703507&r2=703508&view=diff
==============================================================================
--- hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/JobTrackerInstrumentation.java (original)
+++ hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/JobTrackerInstrumentation.java Fri Oct 10 08:50:47 2008
@@ -17,9 +17,7 @@
  */
 package org.apache.hadoop.mapred;
 
-import org.apache.hadoop.metrics.Updater;
-
-public class JobTrackerInstrumentation {
+class JobTrackerInstrumentation {
 
   protected final JobTracker tracker;
   

Modified: hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/QueueManager.java
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/QueueManager.java?rev=703508&r1=703507&r2=703508&view=diff
==============================================================================
--- hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/QueueManager.java (original)
+++ hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/QueueManager.java Fri Oct 10 08:50:47 2008
@@ -19,7 +19,6 @@
 package org.apache.hadoop.mapred;
 
 import java.util.ArrayList;
-import java.util.Collection;
 import java.util.HashMap;
 import java.util.Set;
 import java.util.TreeSet;
@@ -45,7 +44,7 @@
  * queues. Where such a case exists, the queue name must be used to link 
  * the common properties with the scheduler specific ones.  
  */
-public class QueueManager {
+class QueueManager {
   
   private static final Log LOG = LogFactory.getLog(QueueManager.class);
   

Modified: hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/ResourceEstimator.java
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/ResourceEstimator.java?rev=703508&r1=703507&r2=703508&view=diff
==============================================================================
--- hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/ResourceEstimator.java (original)
+++ hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/ResourceEstimator.java Fri Oct 10 08:50:47 2008
@@ -17,7 +17,6 @@
  */
 package org.apache.hadoop.mapred;
 
-import java.util.concurrent.atomic.*;
 import org.apache.commons.logging.Log;
 import org.apache.commons.logging.LogFactory;
 
@@ -29,7 +28,7 @@
  * There is one ResourceEstimator per JobInProgress
  *
  */
-public class ResourceEstimator {
+class ResourceEstimator {
 
   //Log with JobInProgress
   private static final Log LOG = LogFactory.getLog(

Modified: hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/TaskTrackerInstrumentation.java
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/TaskTrackerInstrumentation.java?rev=703508&r1=703507&r2=703508&view=diff
==============================================================================
--- hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/TaskTrackerInstrumentation.java (original)
+++ hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/TaskTrackerInstrumentation.java Fri Oct 10 08:50:47 2008
@@ -31,7 +31,7 @@
  * wouldn't have direct access to the associated TaskTracker.
  *  
  **/
-public class TaskTrackerInstrumentation  {
+class TaskTrackerInstrumentation  {
 
   protected final TaskTracker tt;
   

Modified: hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/TaskTrackerMetricsInst.java
URL: http://svn.apache.org/viewvc/hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/TaskTrackerMetricsInst.java?rev=703508&r1=703507&r2=703508&view=diff
==============================================================================
--- hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/TaskTrackerMetricsInst.java (original)
+++ hadoop/core/trunk/src/mapred/org/apache/hadoop/mapred/TaskTrackerMetricsInst.java Fri Oct 10 08:50:47 2008
@@ -24,7 +24,8 @@
 import org.apache.hadoop.metrics.Updater;
 import org.apache.hadoop.metrics.jvm.JvmMetrics;
   
-public class TaskTrackerMetricsInst extends TaskTrackerInstrumentation implements Updater {
+class TaskTrackerMetricsInst extends TaskTrackerInstrumentation 
+                             implements Updater {
   private final MetricsRecord metricsRecord;
   private int numCompletedTasks = 0;
   private int timedoutTasks = 0;