[GitHub] [incubator-nuttx] pkarashchenko commented on a diff in pull request #6529: net: Ensure sendmsg and sendfile return -EAGAIN in case of timeout

[GitBox <gi...@apache.org>]

pkarashchenko commented on code in PR #6529:
URL: https://github.com/apache/incubator-nuttx/pull/6529#discussion_r907064003


##########
net/sixlowpan/sixlowpan_tcpsend.c:
##########
@@ -660,6 +660,11 @@ static int sixlowpan_send_packet(FAR struct socket *psock,
               ret = net_timedwait(&sinfo.s_waitsem, timeout);
               if (ret != -ETIMEDOUT || acked == sinfo.s_acked)

Review Comment:
   Condition `ret != -ETIMEDOUT` here and then checking for `if (ret == -ETIMEOUT)` makes me feel a bit uncomfortable, but I assume that we are seeking for the `acked == sinfo.s_acked` condition here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org