You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "slavkap (via GitHub)" <gi...@apache.org> on 2024/12/16 10:46:10 UTC
[PR] Disabled the setting `do-not-reboot-host-on-heartbeat-timeout` to not reboot a host on heartbeat timeout [cloudstack]
slavkap opened a new pull request, #10111:
URL: https://github.com/apache/cloudstack/pull/10111
### Description
This PR disables the setting `reboot.host.and.alert.management.on.heartbeat.timeout`. When there is a storage issue, even if the high availability isn't enabled, CloudStack will reboot the host.
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [X] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
- [ ] test (unit or integration test code)
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disabled the setting `reboot.host.and.alert.management.on.heartbeat.timeout` by default [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #10111:
URL: https://github.com/apache/cloudstack/pull/10111#issuecomment-3894956636
Hi @slavkap is this ready for review? can you rebase with 4.22 if this can targeted to 4.22.1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disabled the setting `reboot.host.and.alert.management.on.heartbeat.timeout` by default [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #10111:
URL: https://github.com/apache/cloudstack/pull/10111#issuecomment-2963617294
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disabled the setting `reboot.host.and.alert.management.on.heartbeat.timeout` by default [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #10111:
URL: https://github.com/apache/cloudstack/pull/10111#issuecomment-2965276414
@sureshanaparti , I think we can merge this one, pending smoke tests. But it merits a note in the release notes page for the next version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disabled the setting `reboot.host.and.alert.management.on.heartbeat.timeout` by default [cloudstack]
Posted by "hanisirfan (via GitHub)" <gi...@apache.org>.
hanisirfan commented on PR #10111:
URL: https://github.com/apache/cloudstack/pull/10111#issuecomment-2763197681
As someone who works with VMware products, I never had an experience where a host reboots when datastore are inaccessible. I believe changing the default for CloudStack to "false" is a great move.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disabled the setting `reboot.host.and.alert.management.on.heartbeat.timeout` by default [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10111:
URL: https://github.com/apache/cloudstack/pull/10111#issuecomment-2943480277
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disabled the setting `reboot.host.and.alert.management.on.heartbeat.timeout` by default [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #10111:
URL: https://github.com/apache/cloudstack/pull/10111#issuecomment-2943477036
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disabled the setting `do-not-reboot-host-on-heartbeat-timeout` to not reboot a host on heartbeat timeout [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #10111:
URL: https://github.com/apache/cloudstack/pull/10111#issuecomment-2545632168
@slavkap , have you tested this with HA enabled?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disabled the setting `do-not-reboot-host-on-heartbeat-timeout` to not reboot a host on heartbeat timeout [cloudstack]
Posted by "slavkap (via GitHub)" <gi...@apache.org>.
slavkap commented on PR #10111:
URL: https://github.com/apache/cloudstack/pull/10111#issuecomment-2547993633
@DaanHoogland, I've tested this with and without HA
@weizhouapache, sure, I'll start a discussion for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disabled the setting `reboot.host.and.alert.management.on.heartbeat.timeout` by default [cloudstack]
Posted by "slavkap (via GitHub)" <gi...@apache.org>.
slavkap commented on PR #10111:
URL: https://github.com/apache/cloudstack/pull/10111#issuecomment-2631695930
@DaanHoogland, I rebased it on main as @weizhouapache suggested merging it possibly in a major release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disabled the setting `reboot.host.and.alert.management.on.heartbeat.timeout` by default [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #10111:
URL: https://github.com/apache/cloudstack/pull/10111#issuecomment-2577612625
@slavkap , I changed the title . Hope you don't mind. It was a bit confusing to me.
Are you still looking into this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disabled the setting `reboot.host.and.alert.management.on.heartbeat.timeout` by default [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10111:
URL: https://github.com/apache/cloudstack/pull/10111#issuecomment-2956236681
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13677
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disabled the setting `do-not-reboot-host-on-heartbeat-timeout` to not reboot a host on heartbeat timeout [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #10111:
URL: https://github.com/apache/cloudstack/pull/10111#issuecomment-2545647582
@slavkap
can you start a discussion on dev/user mailing list ?
this changes the current behaviour.
IMHO, if no objections, we could merge it in 4.21(next major release), but not 4.20/4.19
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disabled the setting `reboot.host.and.alert.management.on.heartbeat.timeout` by default [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10111:
URL: https://github.com/apache/cloudstack/pull/10111#issuecomment-2955994049
Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 13671
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disabled the setting `reboot.host.and.alert.management.on.heartbeat.timeout` by default [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #10111:
URL: https://github.com/apache/cloudstack/pull/10111#issuecomment-4905340212
based on approvals on #12664 and previous discussion, merging
we need to add a doc PR for it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disabled the setting `do-not-reboot-host-on-heartbeat-timeout` to not reboot a host on heartbeat timeout [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #10111:
URL: https://github.com/apache/cloudstack/pull/10111#issuecomment-2545256695
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/10111?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 4.30%. Comparing base [(`a2f2e87`)](https://app.codecov.io/gh/apache/cloudstack/commit/a2f2e87c12095387ff2bc09b0d0fd82615d6d361?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`79a5f78`)](https://app.codecov.io/gh/apache/cloudstack/commit/79a5f78b79d8f17c4222839f08900bc075f44610?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> :exclamation: There is a different number of reports uploaded between BASE (a2f2e87) and HEAD (79a5f78). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (a2f2e87) | HEAD (79a5f78) |
>|------|------|------|
>|unittests|1|0|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 4.19 #10111 +/- ##
=============================================
- Coverage 15.13% 4.30% -10.83%
=============================================
Files 5408 366 -5042
Lines 473867 29571 -444296
Branches 57778 5180 -52598
=============================================
- Hits 71700 1272 -70428
+ Misses 394165 28155 -366010
+ Partials 8002 144 -7858
```
| [Flag](https://app.codecov.io/gh/apache/cloudstack/pull/10111/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [uitests](https://app.codecov.io/gh/apache/cloudstack/pull/10111/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `4.30% <ø> (ø)` | |
| [unittests](https://app.codecov.io/gh/apache/cloudstack/pull/10111/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/cloudstack/pull/10111?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disabled the setting `reboot.host.and.alert.management.on.heartbeat.timeout` by default [cloudstack]
Posted by "boubouX (via GitHub)" <gi...@apache.org>.
boubouX commented on PR #10111:
URL: https://github.com/apache/cloudstack/pull/10111#issuecomment-2762200094
We experienced the unfortunate event of this issue, causing cascading reboots of all our hosts while the NFS server had no running VM. It was an operational nightmare that resulted in approximately 45 minutes of downtime. Changing its default value to false offers us more gain than loss. We adjusted it to our settings; thank you, Wei. This was simply catastrophic!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disabled the setting `reboot.host.and.alert.management.on.heartbeat.timeout` by default [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10111:
URL: https://github.com/apache/cloudstack/pull/10111#issuecomment-2963618384
@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disabled the setting `reboot.host.and.alert.management.on.heartbeat.timeout` by default [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10111:
URL: https://github.com/apache/cloudstack/pull/10111#issuecomment-2943899015
Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 13621
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disabled the setting `do-not-reboot-host-on-heartbeat-timeout` to not reboot a host on heartbeat timeout [cloudstack]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #10111:
URL: https://github.com/apache/cloudstack/pull/10111#issuecomment-2547981896
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disabled the setting `reboot.host.and.alert.management.on.heartbeat.timeout` by default [cloudstack]
Posted by "slavkap (via GitHub)" <gi...@apache.org>.
slavkap commented on PR #10111:
URL: https://github.com/apache/cloudstack/pull/10111#issuecomment-2582032101
@DaanHoogland, I don't mind the change, thanks!
Yes, I opened a discussion in the mailing list for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disabled the setting `reboot.host.and.alert.management.on.heartbeat.timeout` by default [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #10111:
URL: https://github.com/apache/cloudstack/pull/10111#issuecomment-2631247878
moved forward
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disabled the setting `reboot.host.and.alert.management.on.heartbeat.timeout` by default [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #10111:
URL: https://github.com/apache/cloudstack/pull/10111#issuecomment-2965899496
<b>[SF] Trillian test result (tid-13502)</b>
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 55426 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10111-t13502-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disabled the setting `reboot.host.and.alert.management.on.heartbeat.timeout` by default [cloudstack]
Posted by "rajujith (via GitHub)" <gi...@apache.org>.
rajujith commented on PR #10111:
URL: https://github.com/apache/cloudstack/pull/10111#issuecomment-3742043726
@slavkap Since this is for the 4.22.1 release, could you retarget the PR to the 4.22 branch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disabled the setting `reboot.host.and.alert.management.on.heartbeat.timeout` by default [cloudstack]
Posted by "sureshanaparti (via GitHub)" <gi...@apache.org>.
sureshanaparti commented on PR #10111:
URL: https://github.com/apache/cloudstack/pull/10111#issuecomment-4312648930
ping @slavkap can you check this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Disabled the setting `reboot.host.and.alert.management.on.heartbeat.timeout` by default [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache merged PR #10111:
URL: https://github.com/apache/cloudstack/pull/10111
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org