You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by "Hyrum K. Wright" <hy...@mail.utexas.edu> on 2008/11/12 16:13:49 UTC
Re: svn commit: r34149 - trunk/subversion/bindings/javahl/native
I'm concerned about this change. I understand that it removes a deprecated
function warning, but the warning is there for a purpose. The Right Way to
solve this problem would be to allow JavaHL to provide the right callbacks for
the updated APIs. Can we revert this change as a reminder to do it right?
-Hyrum
arfrever@tigris.org wrote:
> Author: arfrever
> Date: Tue Nov 11 12:53:51 2008
> New Revision: 34149
>
> Log:
> Don't use deprecated functions in JavaHL.
>
> * subversion/bindings/javahl/native/SVNClient.cpp
> (SVNClient::getContext): Use svn_auth_get_simple_provider2() instead of
> svn_auth_get_simple_provider(). Use
> svn_auth_get_ssl_client_cert_pw_file_provider2() instead of
> svn_auth_get_ssl_client_cert_pw_file_provider().
>
> Modified:
> trunk/subversion/bindings/javahl/native/SVNClient.cpp
>
> Modified: trunk/subversion/bindings/javahl/native/SVNClient.cpp
> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/bindings/javahl/native/SVNClient.cpp?pathrev=34149&r1=34148&r2=34149
> ==============================================================================
> --- trunk/subversion/bindings/javahl/native/SVNClient.cpp Tue Nov 11 12:20:55 2008 (r34148)
> +++ trunk/subversion/bindings/javahl/native/SVNClient.cpp Tue Nov 11 12:53:51 2008 (r34149)
> @@ -1217,7 +1217,7 @@ svn_client_ctx_t *SVNClient::getContext(
> if (provider)
> APR_ARRAY_PUSH(providers, svn_auth_provider_object_t *) = provider;
>
> - svn_auth_get_simple_provider(&provider, pool);
> + svn_auth_get_simple_provider2(&provider, NULL, NULL, pool);
> APR_ARRAY_PUSH(providers, svn_auth_provider_object_t *) = provider;
> svn_auth_get_username_provider(&provider, pool);
> APR_ARRAY_PUSH(providers, svn_auth_provider_object_t *) = provider;
> @@ -1233,7 +1233,8 @@ svn_client_ctx_t *SVNClient::getContext(
> APR_ARRAY_PUSH(providers, svn_auth_provider_object_t *) = provider;
> svn_auth_get_ssl_client_cert_file_provider(&provider, pool);
> APR_ARRAY_PUSH(providers, svn_auth_provider_object_t *) = provider;
> - svn_auth_get_ssl_client_cert_pw_file_provider(&provider, pool);
> + svn_auth_get_ssl_client_cert_pw_file_provider2(&provider, NULL, NULL,
> + pool);
> APR_ARRAY_PUSH(providers, svn_auth_provider_object_t *) = provider;
>
> if (m_prompter != NULL)
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: svn-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: svn-help@subversion.tigris.org
>
>
Re: svn commit: r34149 - trunk/subversion/bindings/javahl/native
Posted by "Hyrum K. Wright" <hy...@mail.utexas.edu>.
Arfrever Frehtes Taifersar Arahesis wrote:
> 2008-11-12 17:13:49 Hyrum K. Wright napisał(a):
>> I'm concerned about this change. I understand that it removes a deprecated
>> function warning, but the warning is there for a purpose. The Right Way to
>> solve this problem would be to allow JavaHL to provide the right callbacks for
>> the updated APIs. Can we revert this change as a reminder to do it right?
>
> OK. I reverted r34149 in r34194 :)
Thanks! (and I like the revision number, too.)
-Hyrum
Re: svn commit: r34149 - trunk/subversion/bindings/javahl/native
Posted by Arfrever Frehtes Taifersar Arahesis <ar...@gmail.com>.
2008-11-12 17:13:49 Hyrum K. Wright napisał(a):
> I'm concerned about this change. I understand that it removes a deprecated
> function warning, but the warning is there for a purpose. The Right Way to
> solve this problem would be to allow JavaHL to provide the right callbacks for
> the updated APIs. Can we revert this change as a reminder to do it right?
OK. I reverted r34149 in r34194 :)
>
> -Hyrum
>
> arfrever@tigris.org wrote:
> > Author: arfrever
> > Date: Tue Nov 11 12:53:51 2008
> > New Revision: 34149
> >
> > Log:
> > Don't use deprecated functions in JavaHL.
> >
> > * subversion/bindings/javahl/native/SVNClient.cpp
> > (SVNClient::getContext): Use svn_auth_get_simple_provider2() instead of
> > svn_auth_get_simple_provider(). Use
> > svn_auth_get_ssl_client_cert_pw_file_provider2() instead of
> > svn_auth_get_ssl_client_cert_pw_file_provider().
> >
> > Modified:
> > trunk/subversion/bindings/javahl/native/SVNClient.cpp
> >
> > Modified: trunk/subversion/bindings/javahl/native/SVNClient.cpp
> > URL: http://svn.collab.net/viewvc/svn/trunk/subversion/bindings/javahl/native/SVNClient.cpp?pathrev=34149&r1=34148&r2=34149
> > ==============================================================================
> > --- trunk/subversion/bindings/javahl/native/SVNClient.cpp Tue Nov 11 12:20:55 2008 (r34148)
> > +++ trunk/subversion/bindings/javahl/native/SVNClient.cpp Tue Nov 11 12:53:51 2008 (r34149)
> > @@ -1217,7 +1217,7 @@ svn_client_ctx_t *SVNClient::getContext(
> > if (provider)
> > APR_ARRAY_PUSH(providers, svn_auth_provider_object_t *) = provider;
> >
> > - svn_auth_get_simple_provider(&provider, pool);
> > + svn_auth_get_simple_provider2(&provider, NULL, NULL, pool);
> > APR_ARRAY_PUSH(providers, svn_auth_provider_object_t *) = provider;
> > svn_auth_get_username_provider(&provider, pool);
> > APR_ARRAY_PUSH(providers, svn_auth_provider_object_t *) = provider;
> > @@ -1233,7 +1233,8 @@ svn_client_ctx_t *SVNClient::getContext(
> > APR_ARRAY_PUSH(providers, svn_auth_provider_object_t *) = provider;
> > svn_auth_get_ssl_client_cert_file_provider(&provider, pool);
> > APR_ARRAY_PUSH(providers, svn_auth_provider_object_t *) = provider;
> > - svn_auth_get_ssl_client_cert_pw_file_provider(&provider, pool);
> > + svn_auth_get_ssl_client_cert_pw_file_provider2(&provider, NULL, NULL,
> > + pool);
> > APR_ARRAY_PUSH(providers, svn_auth_provider_object_t *) = provider;
> >
> > if (m_prompter != NULL)
> >
--
Arfrever Frehtes Taifersar Arahesis
Re: svn commit: r34149 - trunk/subversion/bindings/javahl/native
Posted by Mark Phippard <ma...@gmail.com>.
On Wed, Nov 12, 2008 at 11:28 AM, Hyrum K. Wright
<hy...@mail.utexas.edu> wrote:
> Mark Phippard wrote:
>> On Wed, Nov 12, 2008 at 11:13 AM, Hyrum K. Wright
>> <hy...@mail.utexas.edu> wrote:
>>> I'm concerned about this change. I understand that it removes a deprecated
>>> function warning, but the warning is there for a purpose. The Right Way to
>>> solve this problem would be to allow JavaHL to provide the right callbacks for
>>> the updated APIs. Can we revert this change as a reminder to do it right?
>>
>> I am not aware of all the code involved, but how are we able to use
>> the new functions at all if it is not being done the "right way". If
>> you are concerned, then I am concerned too.
>
> The new functions take NULL arguments in place of the callbacks and basically
> behave as the old functions, so there shouldn't be any functional change with
> this patch.
I hope that is not indicative of a trend in our code in terms of
removing the usage of deprecated functions. If so, I am not sure
these changes we have made to identify deprecated functions is much of
a step forward.
--
Thanks
Mark Phippard
http://markphip.blogspot.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r34149 - trunk/subversion/bindings/javahl/native
Posted by "Hyrum K. Wright" <hy...@mail.utexas.edu>.
Mark Phippard wrote:
> On Wed, Nov 12, 2008 at 11:13 AM, Hyrum K. Wright
> <hy...@mail.utexas.edu> wrote:
>> I'm concerned about this change. I understand that it removes a deprecated
>> function warning, but the warning is there for a purpose. The Right Way to
>> solve this problem would be to allow JavaHL to provide the right callbacks for
>> the updated APIs. Can we revert this change as a reminder to do it right?
>
> I am not aware of all the code involved, but how are we able to use
> the new functions at all if it is not being done the "right way". If
> you are concerned, then I am concerned too.
The new functions take NULL arguments in place of the callbacks and basically
behave as the old functions, so there shouldn't be any functional change with
this patch.
However, these is work to be done, which is my concern, and the deprecated
warnings remind us of that. I've got a half-baked patch right now, but I'm not
really sure that is works or fits the existing JavaHL auth paradigm. I'm
holding off on committing it because I've got some more pressing items on my
plate, and I'd rather not commit a half-patch to trunk right now.
If another JavaHL guru (do we have any?) wants to look at this, be my guest.
-Hyrum
Re: svn commit: r34149 - trunk/subversion/bindings/javahl/native
Posted by Mark Phippard <ma...@gmail.com>.
On Wed, Nov 12, 2008 at 11:13 AM, Hyrum K. Wright
<hy...@mail.utexas.edu> wrote:
> I'm concerned about this change. I understand that it removes a deprecated
> function warning, but the warning is there for a purpose. The Right Way to
> solve this problem would be to allow JavaHL to provide the right callbacks for
> the updated APIs. Can we revert this change as a reminder to do it right?
I am not aware of all the code involved, but how are we able to use
the new functions at all if it is not being done the "right way". If
you are concerned, then I am concerned too.
--
Thanks
Mark Phippard
http://markphip.blogspot.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r34149 - trunk/subversion/bindings/javahl/native
Posted by Mark Phippard <ma...@gmail.com>.
On Thu, Nov 13, 2008 at 4:05 PM, Hyrum K. Wright
<hy...@mail.utexas.edu> wrote:
> So, Arfrever, shall I revert this, or are you planning on doing it? (Or is
> there a reason it should be kept?)
I'd vote for reverting it.
--
Thanks
Mark Phippard
http://markphip.blogspot.com/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: svn commit: r34149 - trunk/subversion/bindings/javahl/native
Posted by "Hyrum K. Wright" <hy...@mail.utexas.edu>.
So, Arfrever, shall I revert this, or are you planning on doing it? (Or is
there a reason it should be kept?)
Thanks,
-Hyrum
Hyrum K. Wright wrote:
> I'm concerned about this change. I understand that it removes a deprecated
> function warning, but the warning is there for a purpose. The Right Way to
> solve this problem would be to allow JavaHL to provide the right callbacks for
> the updated APIs. Can we revert this change as a reminder to do it right?
>
> -Hyrum
>
> arfrever@tigris.org wrote:
>> Author: arfrever
>> Date: Tue Nov 11 12:53:51 2008
>> New Revision: 34149
>>
>> Log:
>> Don't use deprecated functions in JavaHL.
>>
>> * subversion/bindings/javahl/native/SVNClient.cpp
>> (SVNClient::getContext): Use svn_auth_get_simple_provider2() instead of
>> svn_auth_get_simple_provider(). Use
>> svn_auth_get_ssl_client_cert_pw_file_provider2() instead of
>> svn_auth_get_ssl_client_cert_pw_file_provider().
>>
>> Modified:
>> trunk/subversion/bindings/javahl/native/SVNClient.cpp
>>
>> Modified: trunk/subversion/bindings/javahl/native/SVNClient.cpp
>> URL: http://svn.collab.net/viewvc/svn/trunk/subversion/bindings/javahl/native/SVNClient.cpp?pathrev=34149&r1=34148&r2=34149
>> ==============================================================================
>> --- trunk/subversion/bindings/javahl/native/SVNClient.cpp Tue Nov 11 12:20:55 2008 (r34148)
>> +++ trunk/subversion/bindings/javahl/native/SVNClient.cpp Tue Nov 11 12:53:51 2008 (r34149)
>> @@ -1217,7 +1217,7 @@ svn_client_ctx_t *SVNClient::getContext(
>> if (provider)
>> APR_ARRAY_PUSH(providers, svn_auth_provider_object_t *) = provider;
>>
>> - svn_auth_get_simple_provider(&provider, pool);
>> + svn_auth_get_simple_provider2(&provider, NULL, NULL, pool);
>> APR_ARRAY_PUSH(providers, svn_auth_provider_object_t *) = provider;
>> svn_auth_get_username_provider(&provider, pool);
>> APR_ARRAY_PUSH(providers, svn_auth_provider_object_t *) = provider;
>> @@ -1233,7 +1233,8 @@ svn_client_ctx_t *SVNClient::getContext(
>> APR_ARRAY_PUSH(providers, svn_auth_provider_object_t *) = provider;
>> svn_auth_get_ssl_client_cert_file_provider(&provider, pool);
>> APR_ARRAY_PUSH(providers, svn_auth_provider_object_t *) = provider;
>> - svn_auth_get_ssl_client_cert_pw_file_provider(&provider, pool);
>> + svn_auth_get_ssl_client_cert_pw_file_provider2(&provider, NULL, NULL,
>> + pool);
>> APR_ARRAY_PUSH(providers, svn_auth_provider_object_t *) = provider;
>>
>> if (m_prompter != NULL)
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: svn-unsubscribe@subversion.tigris.org
>> For additional commands, e-mail: svn-help@subversion.tigris.org
>>
>>
>
>