[GitHub] [doris] morrySnow commented on a diff in pull request #11434: [improvement](fe) Remove constant keys in aggregation

[GitBox <gi...@apache.org>]

morrySnow commented on code in PR #11434:
URL: https://github.com/apache/doris/pull/11434#discussion_r935225782


##########
fe/fe-core/src/main/java/org/apache/doris/analysis/AggregateInfoBase.java:
##########
@@ -95,6 +95,10 @@ protected AggregateInfoBase(AggregateInfoBase other) {
         materializedSlots = Lists.newArrayList(other.materializedSlots);
     }
 
+    public void removeConstantKeys() {
+        aggregateExprs.removeIf(expr -> expr.isConstant());

Review Comment:
   👍🏻
   ```suggestion
           groupingExprs.removeIf(Expr::isConstant);
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org