You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@accumulo.apache.org by "EdColeman (via GitHub)" <gi...@apache.org> on 2024/05/14 22:16:20 UTC

[I] Scan Server ZooKeeper entries are not removed on shutdown. [accumulo]

EdColeman opened a new issue, #4559:
URL: https://github.com/apache/accumulo/issues/4559

   The scan servers write a lock with a path similar to:  `/accumulo/[IID]/sservers/host:port/zlock#[LOCK_UUID]#[LOCK_SEQ]`
   
   The lock nodes are ephemeral and are removed if the server cannot renew the lease.  However, the host:port part of the path is persistent, even across ZooKeeper restarts.  The `.../sservers/host:port`  path should be removed if a scan server is shutdown and  there should be a cleaner thread that removes scan servers that do not have a lock if the scan server was not shutdown cleanly.
   
   There should be similar code that is used for teservers that maybe could be reused or adopted.
   
   This may apply to other services like external compactors, but not sure.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Scan Server ZooKeeper entries are not removed on shutdown. [accumulo]

Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on issue #4559:
URL: https://github.com/apache/accumulo/issues/4559#issuecomment-2113171209

   `CompactionCoordinator.cleanUpCompactors` performs clean up of ZooKeeper entries for Compactors that no longer exist. `LiveTServerSet.startListeningForTabletServerChanges` which is called from the Manager and the CompactionCoordinator remove ZooKeeper entries for TabletServers that no longer exist. Currently only the Client code and ZooKeeper have any reference to ScanServers. No other Accumulo process is aware of them. I can add something in the Manager that does the clean up.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Scan Server ZooKeeper entries are not removed on shutdown. [accumulo]

Posted by "keith-turner (via GitHub)" <gi...@apache.org>.
keith-turner commented on issue #4559:
URL: https://github.com/apache/accumulo/issues/4559#issuecomment-2111252529

   #4560 is a duplicate, so closing it.  It has some code links for the tsever and compactor code.   Could not find anything for scan servers.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Scan Server ZooKeeper entries are not removed on shutdown. [accumulo]

Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion commented on issue #4559:
URL: https://github.com/apache/accumulo/issues/4559#issuecomment-2112614868

   > The .../sservers/host:port path should be removed if a scan server is shutdown
   
   > there should be a cleaner thread that removes scan servers that do not have a lock if the scan server was not shutdown cleanly.
   
   Agreed, sounds like these are missing. As an aside, ZooZap can clean them up, and does so on a shutdown when using `accumulo-cluster`, ref [here](https://github.com/apache/accumulo/blob/2.1/assemble/bin/accumulo-cluster#L421). 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Scan Server ZooKeeper entries are not removed on shutdown. [accumulo]

Posted by "dlmarion (via GitHub)" <gi...@apache.org>.
dlmarion closed issue #4559: Scan Server ZooKeeper entries are not removed on shutdown.
URL: https://github.com/apache/accumulo/issues/4559


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org