[GitHub] [jackrabbit-filevault] kwin commented on a diff in pull request #273: JCRVLT-684: test coverage and fix for bug in mixin restoration

["kwin (via GitHub)" <gi...@apache.org>]

kwin commented on code in PR #273:
URL: https://github.com/apache/jackrabbit-filevault/pull/273#discussion_r1105799454


##########
vault-core/src/test/resources/test-packages/stashing.zip/META-INF/vault/definition/.content.xml:
##########
@@ -0,0 +1,25 @@
+<?xml version="1.0" encoding="UTF-8"?>

Review Comment:
   no need to add that



##########
vault-core/src/test/resources/test-packages/stashing.zip/META-INF/vault/config.xml:
##########
@@ -0,0 +1,86 @@
+<!--

Review Comment:
   no need to add that



##########
vault-core/src/test/resources/test-packages/stashing2.zip/META-INF/vault/config.xml:
##########
@@ -0,0 +1,86 @@
+<!--

Review Comment:
   not necessary, please remove



##########
vault-core/src/test/resources/test-packages/stashing2.zip/META-INF/vault/definition/.content.xml:
##########
@@ -0,0 +1,25 @@
+<?xml version="1.0" encoding="UTF-8"?>

Review Comment:
   please remove



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jackrabbit.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org