You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2022/10/10 10:44:25 UTC
[GitHub] [rocketmq-apis] lollipopjin opened a new pull request, #64: add dlq information to message's systemProperties
lollipopjin opened a new pull request, #64:
URL: https://github.com/apache/rocketmq-apis/pull/64
add dlq information to message's systemProperties
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-apis] aaron-ai commented on a diff in pull request #64: add dlq information to message's systemProperties
Posted by GitBox <gi...@apache.org>.
aaron-ai commented on code in PR #64:
URL: https://github.com/apache/rocketmq-apis/pull/64#discussion_r991173302
##########
apache/rocketmq/v2/definition.proto:
##########
@@ -266,6 +266,16 @@ message SystemProperties {
// orphan. Servers that manages orphan messages would pick up
// a capable publisher to resolve
optional google.protobuf.Duration orphaned_transaction_recovery_duration = 19;
+
+ // Infomation to identify whether this message is from dead letter queue.
+ optional Dlq dlq = 20;
Review Comment:
how about renaming to DeadLetterQueue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [rocketmq-apis] lizhanhui merged pull request #64: add dlq information to message's systemProperties
Posted by GitBox <gi...@apache.org>.
lizhanhui merged PR #64:
URL: https://github.com/apache/rocketmq-apis/pull/64
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org