You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2019/05/13 09:14:05 UTC
[GitHub] [tinkerpop] jorgebay commented on a change in pull request #1112:
TINKERPOP-2089 Added DSL support to gremlin-javascript
jorgebay commented on a change in pull request #1112: TINKERPOP-2089 Added DSL support to gremlin-javascript
URL: https://github.com/apache/tinkerpop/pull/1112#discussion_r283250472
##########
File path: gremlin-javascript/src/main/javascript/gremlin-javascript/lib/process/anonymous-traversal.js
##########
@@ -31,13 +31,17 @@ const Graph = require('../structure/graph').Graph;
*/
class AnonymousTraversalSource {
+ constructor(traversalSourceClass) {
+ this.traversalSourceClass = traversalSourceClass;
+ }
+
/**
* Constructs an {@code AnonymousTraversalSource} which will then be configured to spawn a
* {@link GraphTraversalSource}.
* @returns {AnonymousTraversalSource}.
*/
- static traversal() {
- return new AnonymousTraversalSource();
+ static traversal(traversalSourceClass) {
Review comment:
We should document in jsdoc: `@param {GraphTraversalSource} [traversalSourceClass] Optional GraphTraversalSource constructor.`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services