You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2021/02/01 14:31:00 UTC
[jira] [Commented] (DISPATCH-1939) Add uniform CMake options for
optional dependencies (-DUSE_X=OFF)
[ https://issues.apache.org/jira/browse/DISPATCH-1939?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17276368#comment-17276368 ]
ASF GitHub Bot commented on DISPATCH-1939:
------------------------------------------
jiridanek merged pull request #1008:
URL: https://github.com/apache/qpid-dispatch/pull/1008
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
> Add uniform CMake options for optional dependencies (-DUSE_X=OFF)
> -----------------------------------------------------------------
>
> Key: DISPATCH-1939
> URL: https://issues.apache.org/jira/browse/DISPATCH-1939
> Project: Qpid Dispatch
> Issue Type: Improvement
> Affects Versions: 1.14.0, 1.15.0
> Reporter: Jiri Daněk
> Priority: Major
>
> This pattern is already used for libWebSockets. It is in CMakeLists.txt.
> {noformat}
> CMAKE_DEPENDENT_OPTION(USE_LIBNGHTTP2 "Use libnghttp2 for HTTP/2 support" ON
> "libnghttp2_FOUND" OFF)
> {noformat}
> Users should have a final say whether they want HTTP/2 support or not. If we condition this on the {{libnghttp2_FOUND}} directly, they have to uninstall the library to build Dispatch without HTTP/2 support. With the new option, users can directly say whether they want HTTP/2 support or not.
> The name of the variable could be better, maybe? Something like {{QD_USE_LIBNGHTTP2}} or maybe {{QD_ENABLE_HTTP2}}? But then i'd have to rename the other one too, and would have to create alias for backwards compatibility....
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org