You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tuscany.apache.org by "Fuhwei Lwo (JIRA)" <tu...@ws.apache.org> on 2006/10/28 14:48:16 UTC
[jira] Created: (TUSCANY-885) Property
DataObject.getProperty(String propertyName) should return null if the
property cannot be found
Property DataObject.getProperty(String propertyName) should return null if the property cannot be found
-------------------------------------------------------------------------------------------------------
Key: TUSCANY-885
URL: http://issues.apache.org/jira/browse/TUSCANY-885
Project: Tuscany
Issue Type: Bug
Components: Java SDO Implementation
Affects Versions: Java-Mx
Reporter: Fuhwei Lwo
Priority: Minor
Based on SDO 2.01 specification, DataObject.getProperty(String propertyName) should return null if the property cannot be found. Unfortunately, it returns IlegalArgumentException now.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
Re: [jira] Commented: (TUSCANY-885) Property DataObject.getProperty(String propertyName) should return null if the property cannot be found
Posted by Brent Daniel <br...@gmail.com>.
This is not correct. In this test case there is no property named
"CUSTOMER" defined. The issue is that you can't call getList() with a
property name that does not exist. When the code is changed to throw
null, some upstream code in the getList() implementation will return
the parent DataObject rather than null, eventually resulting in a
ClassCastException.
I'm going to re-enable the test and change the property to something
like "nonExistantProperty" to make this clearer.
Brent
On 11/14/06, Kelvin Goodson (JIRA) <tu...@ws.apache.org> wrote:
> [ http://issues.apache.org/jira/browse/TUSCANY-885?page=comments#action_12449772 ]
>
> Kelvin Goodson commented on TUSCANY-885:
> ----------------------------------------
>
> The fix applied would seem to have exposed an issue with the TestCase, as there would seem to be a !isMany property referenced by the "CUSTOMER" property name. Attempting to get this single valued property as a list is causing the problem. I have commented out the test case a luciano's request.
>
> > Property DataObject.getProperty(String propertyName) should return null if the property cannot be found
> > -------------------------------------------------------------------------------------------------------
> >
> > Key: TUSCANY-885
> > URL: http://issues.apache.org/jira/browse/TUSCANY-885
> > Project: Tuscany
> > Issue Type: Bug
> > Components: Java SDO Implementation
> > Affects Versions: Java-Mx
> > Reporter: Fuhwei Lwo
> > Assigned To: Kelvin Goodson
> > Priority: Minor
> > Fix For: Java-Mx
> >
> > Attachments: tuscany-885.patch
> >
> >
> > Based on SDO 2.01 specification, DataObject.getProperty(String propertyName) should return null if the property cannot be found. Unfortunately, it returns IlegalArgumentException now.
>
> --
> This message is automatically generated by JIRA.
> -
> If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
> -
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
> For additional commands, e-mail: tuscany-dev-help@ws.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Commented: (TUSCANY-885) Property
DataObject.getProperty(String propertyName) should return null if the
property cannot be found
Posted by "Yang ZHONG (JIRA)" <tu...@ws.apache.org>.
[ http://issues.apache.org/jira/browse/TUSCANY-885?page=comments#action_12451460 ]
Yang ZHONG commented on TUSCANY-885:
------------------------------------
932 fix may solve this issue too, except DAS still needs to fix its Test Case.
> Property DataObject.getProperty(String propertyName) should return null if the property cannot be found
> -------------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-885
> URL: http://issues.apache.org/jira/browse/TUSCANY-885
> Project: Tuscany
> Issue Type: Bug
> Components: Java SDO Implementation
> Affects Versions: Java-Mx
> Reporter: Fuhwei Lwo
> Assigned To: Kelvin Goodson
> Priority: Minor
> Fix For: Java-Mx
>
> Attachments: tuscany-885.patch
>
>
> Based on SDO 2.01 specification, DataObject.getProperty(String propertyName) should return null if the property cannot be found. Unfortunately, it returns IlegalArgumentException now.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Commented: (TUSCANY-885) Property
DataObject.getProperty(String propertyName) should return null if the
property cannot be found
Posted by "Kelvin Goodson (JIRA)" <tu...@ws.apache.org>.
[ http://issues.apache.org/jira/browse/TUSCANY-885?page=comments#action_12449772 ]
Kelvin Goodson commented on TUSCANY-885:
----------------------------------------
The fix applied would seem to have exposed an issue with the TestCase, as there would seem to be a !isMany property referenced by the "CUSTOMER" property name. Attempting to get this single valued property as a list is causing the problem. I have commented out the test case a luciano's request.
> Property DataObject.getProperty(String propertyName) should return null if the property cannot be found
> -------------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-885
> URL: http://issues.apache.org/jira/browse/TUSCANY-885
> Project: Tuscany
> Issue Type: Bug
> Components: Java SDO Implementation
> Affects Versions: Java-Mx
> Reporter: Fuhwei Lwo
> Assigned To: Kelvin Goodson
> Priority: Minor
> Fix For: Java-Mx
>
> Attachments: tuscany-885.patch
>
>
> Based on SDO 2.01 specification, DataObject.getProperty(String propertyName) should return null if the property cannot be found. Unfortunately, it returns IlegalArgumentException now.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Reopened: (TUSCANY-885) Property
DataObject.getProperty(String propertyName) should return null if the
property cannot be found
Posted by "Kevin Williams (JIRA)" <tu...@ws.apache.org>.
[ http://issues.apache.org/jira/browse/TUSCANY-885?page=all ]
Kevin Williams reopened TUSCANY-885:
------------------------------------
Brent pointed out that the DAS test case is valid and seems to be exposing a problem with the patch associated with this JIRA:
"The issue is that you can't call getList() with a
property name that does not exist. When the code is changed to throw
null, some upstream code in the getList() implementation will return
the parent DataObject rather than null, eventually resulting in a
ClassCastException.
I'm going to re-enable the test and change the property to something
like "nonExistantProperty" to make this clearer. "
> Property DataObject.getProperty(String propertyName) should return null if the property cannot be found
> -------------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-885
> URL: http://issues.apache.org/jira/browse/TUSCANY-885
> Project: Tuscany
> Issue Type: Bug
> Components: Java SDO Implementation
> Affects Versions: Java-Mx
> Reporter: Fuhwei Lwo
> Assigned To: Kelvin Goodson
> Priority: Minor
> Fix For: Java-Mx
>
> Attachments: tuscany-885.patch
>
>
> Based on SDO 2.01 specification, DataObject.getProperty(String propertyName) should return null if the property cannot be found. Unfortunately, it returns IlegalArgumentException now.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Updated: (TUSCANY-885) Property
DataObject.getProperty(String propertyName) should return null if the
property cannot be found
Posted by "Fuhwei Lwo (JIRA)" <tu...@ws.apache.org>.
[ http://issues.apache.org/jira/browse/TUSCANY-885?page=all ]
Fuhwei Lwo updated TUSCANY-885:
-------------------------------
Attachment: tuscany-885.patch
Fixed DataObjectUtil.getOpenFeature() to return null instead of IllegalArgumentException.
> Property DataObject.getProperty(String propertyName) should return null if the property cannot be found
> -------------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-885
> URL: http://issues.apache.org/jira/browse/TUSCANY-885
> Project: Tuscany
> Issue Type: Bug
> Components: Java SDO Implementation
> Affects Versions: Java-Mx
> Reporter: Fuhwei Lwo
> Priority: Minor
> Attachments: tuscany-885.patch
>
>
> Based on SDO 2.01 specification, DataObject.getProperty(String propertyName) should return null if the property cannot be found. Unfortunately, it returns IlegalArgumentException now.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Resolved: (TUSCANY-885) Property
DataObject.getProperty(String propertyName) should return null if the
property cannot be found
Posted by "Kelvin Goodson (JIRA)" <tu...@ws.apache.org>.
[ http://issues.apache.org/jira/browse/TUSCANY-885?page=all ]
Kelvin Goodson resolved TUSCANY-885.
------------------------------------
Resolution: Fixed
fixed in 478825
> Property DataObject.getProperty(String propertyName) should return null if the property cannot be found
> -------------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-885
> URL: http://issues.apache.org/jira/browse/TUSCANY-885
> Project: Tuscany
> Issue Type: Bug
> Components: Java SDO Implementation
> Affects Versions: Java-Mx
> Reporter: Fuhwei Lwo
> Assigned To: Kelvin Goodson
> Priority: Minor
> Fix For: Java-Mx
>
> Attachments: DAS_885.txt, tuscany-885.patch
>
>
> Based on SDO 2.01 specification, DataObject.getProperty(String propertyName) should return null if the property cannot be found. Unfortunately, it returns IlegalArgumentException now.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Updated: (TUSCANY-885) Property
DataObject.getProperty(String propertyName) should return null if the
property cannot be found
Posted by "Frank Budinsky (JIRA)" <tu...@ws.apache.org>.
[ http://issues.apache.org/jira/browse/TUSCANY-885?page=all ]
Frank Budinsky updated TUSCANY-885:
-----------------------------------
Priority: Minor (was: Blocker)
Temporarily reversed this change in revision 475408.
Proper fix requires also changing Accessor.process() to handle invalid property names.
The DAS test case should also be changed to handle null return, instead of IlliegalArgumentException, because the current Tuscany implementation is not conformant with the spec and still needs to be fixed.
> Property DataObject.getProperty(String propertyName) should return null if the property cannot be found
> -------------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-885
> URL: http://issues.apache.org/jira/browse/TUSCANY-885
> Project: Tuscany
> Issue Type: Bug
> Components: Java SDO Implementation
> Affects Versions: Java-Mx
> Reporter: Fuhwei Lwo
> Assigned To: Kelvin Goodson
> Priority: Minor
> Fix For: Java-Mx
>
> Attachments: tuscany-885.patch
>
>
> Based on SDO 2.01 specification, DataObject.getProperty(String propertyName) should return null if the property cannot be found. Unfortunately, it returns IlegalArgumentException now.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Resolved: (TUSCANY-885) Property
DataObject.getProperty(String propertyName) should return null if the
property cannot be found
Posted by "Kelvin Goodson (JIRA)" <tu...@ws.apache.org>.
[ http://issues.apache.org/jira/browse/TUSCANY-885?page=all ]
Kelvin Goodson resolved TUSCANY-885.
------------------------------------
Fix Version/s: Java-Mx
Resolution: Fixed
Assignee: Kelvin Goodson
Fuhwei's patch looked good, so I applied and tested it.
> Property DataObject.getProperty(String propertyName) should return null if the property cannot be found
> -------------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-885
> URL: http://issues.apache.org/jira/browse/TUSCANY-885
> Project: Tuscany
> Issue Type: Bug
> Components: Java SDO Implementation
> Affects Versions: Java-Mx
> Reporter: Fuhwei Lwo
> Assigned To: Kelvin Goodson
> Priority: Minor
> Fix For: Java-Mx
>
> Attachments: tuscany-885.patch
>
>
> Based on SDO 2.01 specification, DataObject.getProperty(String propertyName) should return null if the property cannot be found. Unfortunately, it returns IlegalArgumentException now.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Updated: (TUSCANY-885) Property
DataObject.getProperty(String propertyName) should return null if the
property cannot be found
Posted by "Kevin Williams (JIRA)" <tu...@ws.apache.org>.
[ http://issues.apache.org/jira/browse/TUSCANY-885?page=all ]
Kevin Williams updated TUSCANY-885:
-----------------------------------
Attachment: DAS_885.txt
This patch is to convert the single DAS test case that depends on IllegalArgumentException. It shoud be applied at the same time to avoid a build break.
> Property DataObject.getProperty(String propertyName) should return null if the property cannot be found
> -------------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-885
> URL: http://issues.apache.org/jira/browse/TUSCANY-885
> Project: Tuscany
> Issue Type: Bug
> Components: Java SDO Implementation
> Affects Versions: Java-Mx
> Reporter: Fuhwei Lwo
> Assigned To: Kelvin Goodson
> Priority: Minor
> Fix For: Java-Mx
>
> Attachments: DAS_885.txt, tuscany-885.patch
>
>
> Based on SDO 2.01 specification, DataObject.getProperty(String propertyName) should return null if the property cannot be found. Unfortunately, it returns IlegalArgumentException now.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Updated: (TUSCANY-885) Property
DataObject.getProperty(String propertyName) should return null if the
property cannot be found
Posted by "Kevin Williams (JIRA)" <tu...@ws.apache.org>.
[ http://issues.apache.org/jira/browse/TUSCANY-885?page=all ]
Kevin Williams updated TUSCANY-885:
-----------------------------------
Priority: Blocker (was: Minor)
> Property DataObject.getProperty(String propertyName) should return null if the property cannot be found
> -------------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-885
> URL: http://issues.apache.org/jira/browse/TUSCANY-885
> Project: Tuscany
> Issue Type: Bug
> Components: Java SDO Implementation
> Affects Versions: Java-Mx
> Reporter: Fuhwei Lwo
> Assigned To: Kelvin Goodson
> Priority: Blocker
> Fix For: Java-Mx
>
> Attachments: tuscany-885.patch
>
>
> Based on SDO 2.01 specification, DataObject.getProperty(String propertyName) should return null if the property cannot be found. Unfortunately, it returns IlegalArgumentException now.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Commented: (TUSCANY-885) Property
DataObject.getProperty(String propertyName) should return null if the
property cannot be found
Posted by "Luciano Resende (JIRA)" <tu...@ws.apache.org>.
[ http://issues.apache.org/jira/browse/TUSCANY-885?page=comments#action_12449716 ]
Luciano Resende commented on TUSCANY-885:
-----------------------------------------
After this changes, DAS test case is failing at :
Running org.apache.tuscany.das.rdb.test.suites.AllTestsDerby
Setting up for Derby run
Ending Derby run
Tests run: 140, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 21.688 sec <<<
FAILURE!
testReadSingleVerifyShapeUse(org.apache.tuscany.das.rdb.test.ResultSetShapeTests
) Time elapsed: 0.078 sec <<< ERROR!
java.lang.ClassCastException: org.apache.tuscany.sdo.impl.DynamicDataObjectImpl
incompatible with java.util.List
at org.apache.tuscany.sdo.impl.DataObjectImpl.getList(DataObjectImpl.jav
a:376)
at org.apache.tuscany.das.rdb.test.ResultSetShapeTests.testReadSingleVer
ifyShapeUse(ResultSetShapeTests.java:85)
> Property DataObject.getProperty(String propertyName) should return null if the property cannot be found
> -------------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-885
> URL: http://issues.apache.org/jira/browse/TUSCANY-885
> Project: Tuscany
> Issue Type: Bug
> Components: Java SDO Implementation
> Affects Versions: Java-Mx
> Reporter: Fuhwei Lwo
> Assigned To: Kelvin Goodson
> Priority: Minor
> Fix For: Java-Mx
>
> Attachments: tuscany-885.patch
>
>
> Based on SDO 2.01 specification, DataObject.getProperty(String propertyName) should return null if the property cannot be found. Unfortunately, it returns IlegalArgumentException now.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Updated: (TUSCANY-885) Property
DataObject.getProperty(String propertyName) should return null if the
property cannot be found
Posted by "Kelvin Goodson (JIRA)" <tu...@ws.apache.org>.
[ https://issues.apache.org/jira/browse/TUSCANY-885?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kelvin Goodson updated TUSCANY-885:
-----------------------------------
Fix Version/s: (was: Java-SCA-Mx)
Java-SDO-M3
> Property DataObject.getProperty(String propertyName) should return null if the property cannot be found
> -------------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-885
> URL: https://issues.apache.org/jira/browse/TUSCANY-885
> Project: Tuscany
> Issue Type: Bug
> Components: Java SDO Implementation
> Affects Versions: Java-SCA-Mx
> Reporter: Fuhwei Lwo
> Assigned To: Kelvin Goodson
> Priority: Minor
> Fix For: Java-SDO-M3
>
> Attachments: DAS_885.txt, tuscany-885.patch
>
>
> Based on SDO 2.01 specification, DataObject.getProperty(String propertyName) should return null if the property cannot be found. Unfortunately, it returns IlegalArgumentException now.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org
[jira] Commented: (TUSCANY-885) Property
DataObject.getProperty(String propertyName) should return null if the
property cannot be found
Posted by "Yang ZHONG (JIRA)" <tu...@ws.apache.org>.
[ http://issues.apache.org/jira/browse/TUSCANY-885?page=comments#action_12452041 ]
Yang ZHONG commented on TUSCANY-885:
------------------------------------
http://issues.apache.org/jira/secure/attachment/12345504/RevisedPatchWithTest
has been attached to 932.
DAS needs to fix its Test Case please.
> Property DataObject.getProperty(String propertyName) should return null if the property cannot be found
> -------------------------------------------------------------------------------------------------------
>
> Key: TUSCANY-885
> URL: http://issues.apache.org/jira/browse/TUSCANY-885
> Project: Tuscany
> Issue Type: Bug
> Components: Java SDO Implementation
> Affects Versions: Java-Mx
> Reporter: Fuhwei Lwo
> Assigned To: Kelvin Goodson
> Priority: Minor
> Fix For: Java-Mx
>
> Attachments: tuscany-885.patch
>
>
> Based on SDO 2.01 specification, DataObject.getProperty(String propertyName) should return null if the property cannot be found. Unfortunately, it returns IlegalArgumentException now.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: tuscany-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: tuscany-dev-help@ws.apache.org