You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2019/12/07 21:00:14 UTC

[GitHub] [netbeans] matthiasblaesing commented on a change in pull request #1741: [NETBEANS-3543] Corrected compiler warnings in extide/o.apache.tools.…

matthiasblaesing commented on a change in pull request #1741: [NETBEANS-3543] Corrected compiler warnings in extide/o.apache.tools.…
URL: https://github.com/apache/netbeans/pull/1741#discussion_r355143159
 
 

 ##########
 File path: extide/o.apache.tools.ant.module/src-bridge/org/apache/tools/ant/module/bridge/impl/BridgeImpl.java
 ##########
 @@ -442,10 +440,10 @@ public PostRun(Project project, NbBuildLogger logger) {
         public @Override void run() {
             IntrospectedInfo custom = AntSettings.getCustomDefs();
             @SuppressWarnings("rawtypes")
-            Map<String,Map<String,Class>> defs = new HashMap<String, Map<String, Class>>();
+            Map<String,Map<String,Class<?>>> defs = new HashMap<String, Map<String, Class<?>>>();
             try {
-                defs.put("task", NbCollections.checkedMapByCopy(project.getTaskDefinitions(), String.class, Class.class, true));
-                defs.put("type", NbCollections.checkedMapByCopy(project.getDataTypeDefinitions(), String.class, Class.class, true));
+                defs.put("task", project.getTaskDefinitions());
+                defs.put("type", project.getDataTypeDefinitions());
 
 Review comment:
   This changes the semantics. Before the change a copy of the map is created, after the map itself is added.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists