[GitHub] [kafka] divijvaidya commented on pull request #13421: KAFKA-14824: ReplicaAlterLogDirsThread may cause serious disk growing in case of potential exception

["divijvaidya (via GitHub)" <gi...@apache.org>]

divijvaidya commented on PR #13421:
URL: https://github.com/apache/kafka/pull/13421#issuecomment-1488620100

   Hi @hudeqi 
   If I understand the motivation correctly, in the current behaviour, we pause log cleaners for offline partitions. Since these logs are never cleaned up, they will remain on disk forever. Hence, we want to clean up disk even for partitions which have been marked as failed/offline. Is that right?
   
   This is the same situation when a LogDirectory fails as well. 
   
   In the case of LogDirectory, we expect an external intervention such as "DeleteTopic" or a reassignment to resolve the situation. Both these actions will invoke AsyncDelete and clean up remaining data.
   
   Shouldn't the same apply for your situation as well?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org