You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/06/02 00:49:04 UTC

[GitHub] [druid] himanshug commented on pull request #9717: remove DruidLeaderClient.goAsync(..) that does not follow redirect. Replace its usage by DruidLeaderClient.go(..) with InputStreamFullResponseHandler

himanshug commented on pull request #9717:
URL: https://github.com/apache/druid/pull/9717#issuecomment-637202758


   @surekhasaharan thanks for checking.
   yeah, I noticed that we recently added code coverage expectation to builds. changes here is mostly updating existing  code and  new classes `InputStreamResponse***` are don't have much  logic except for calling methods , ideally we could unit test it with mocks but I am not sure how much value is there.
   many PRs appear to be struggling with new requirement ... maybe the newly introduced expectation around code coverage needs to be tuned down a bit.
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org