You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/05/17 17:49:04 UTC
[jira] [Commented] (ARTEMIS-1172) ActiveMQServerPlugin
beforeDeliver and afterDeliver should pass in the ServerConsumer
[ https://issues.apache.org/jira/browse/ARTEMIS-1172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014492#comment-16014492 ]
ASF GitHub Bot commented on ARTEMIS-1172:
-----------------------------------------
GitHub user cshannon opened a pull request:
https://github.com/apache/activemq-artemis/pull/1277
ARTEMIS-1172 - Update beforeDeliver and afterDeliver method arguments
Adding ServerConsumer as an argument to both the beforeDeliver and
afterDeliver methods inside ActiveMQServerPlugin and deprecated the old
methods
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cshannon/activemq-artemis ARTEMIS-1172
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1277.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1277
----
commit 17d11a2804aa235a2a9768ee1b0a9251353e4121
Author: Christopher L. Shannon (cshannon) <ch...@gmail.com>
Date: 2017-05-17T17:45:22Z
ARTEMIS-1172 - Update beforeDeliver and afterDeliver method arguments
Adding ServerConsumer as an argument to both the beforeDeliver and
afterDeliver methods inside ActiveMQServerPlugin and deprecated the old
methods
----
> ActiveMQServerPlugin beforeDeliver and afterDeliver should pass in the ServerConsumer
> -------------------------------------------------------------------------------------
>
> Key: ARTEMIS-1172
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1172
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
> Affects Versions: 2.1.0
> Reporter: Christopher L. Shannon
> Assignee: Christopher L. Shannon
> Fix For: 2.2.0
>
>
> I forgot to add the ServerConsumer to both the beforeDeliver and afterDeliver plugin methods that matches where the message will/has been delivered to. The consumer should be added as an argument and the old methods should be deprecated and eventually removed (probably in Artemis 3.0)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)