You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "tiagobento (via GitHub)" <gi...@apache.org> on 2024/02/16 17:59:54 UTC
[PR] kie-issues#944: On the DMN Editor, all buttons that have no displayed text should have a title. [incubator-kie-tools]
tiagobento opened a new pull request, #2163:
URL: https://github.com/apache/incubator-kie-tools/pull/2163
Closes https://github.com/apache/incubator-kie-issues/issues/944
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#944: On the DMN Editor, all buttons that have no displayed text should have a title. [incubator-kie-tools]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento commented on code in PR #2163:
URL: https://github.com/apache/incubator-kie-tools/pull/2163#discussion_r1496568519
##########
packages/dmn-editor/src/dataTypes/DataTypes.tsx:
##########
@@ -197,6 +199,7 @@ export function DataTypes() {
id="add-data-type-toggle"
splitButtonItems={[
<DropdownToggleAction
+ {...extraPropsForDropdownToggleAction}
Review Comment:
Added a comment...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#944: On the DMN Editor, all buttons that have no displayed text should have a title. [incubator-kie-tools]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento commented on PR #2163:
URL: https://github.com/apache/incubator-kie-tools/pull/2163#issuecomment-1954776507
@jomarko Yeah, I preferred to leave it as inferable from context, but I see your point. I can change it to be more specific, of course. However, I must say that we shouldn't start compromising on UI/UX in order for tests to be more easily written. I think we should of course keep tests in mind with everything that we do. IMHO we should always think what's the best UX possible for users, then figure out how to test it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org
Re: [PR] kie-issues#944: On the DMN Editor, all buttons that have no displayed text should have a title. [incubator-kie-tools]
Posted by "tiagobento (via GitHub)" <gi...@apache.org>.
tiagobento merged PR #2163:
URL: https://github.com/apache/incubator-kie-tools/pull/2163
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org